Adding requirements for blocks (AuraSkillsLevelRestrict) #342
Conversation
bukkit/src/main/java/dev/aurelium/auraskills/bukkit/requirement/RequirementManager.java
Show resolved
Hide resolved
| private final Material material; | ||
| private final boolean checksPlace; | ||
| private final boolean checksBreak; | ||
| private final LinkedList<RequirementNode> nodes; |
There was a problem hiding this comment.
Use the abstract List type here instead of LinkedList, same for all other places in this class.
There was a problem hiding this comment.
alr, the initial goal was to supply it with a ordered structure so whatever you added, it will be checked with the given order, allowing more specific messages
|
|
||
| protected AuraSkills plugin; | ||
|
|
||
| public RequirementNode(AuraSkills plugin) { |
There was a problem hiding this comment.
The deny message can be stored and passed in the constructor of the abstract class here. Then you only need to implement the getDenyMessage method once here and not multiple times in each requirement type.
| this.message = message; | ||
| } | ||
|
|
||
| public boolean check(Player player) { |
| this.message = message; | ||
| } | ||
|
|
||
| public boolean check(Player player) { |
| this.message = message; | ||
| } | ||
|
|
||
| public boolean check(Player player) { |
| @@ -163,4 +167,22 @@ private void checkItemRequirements(Player player, ItemStack item, Cancellable ev | |||
| } | |||
| } | |||
|
|
|||
| private void checkBlockRequirements(Player player, Material material, Cancellable event) { | |||
| BlockRequirement blockRequirement = manager.getBlocks().stream().filter(b -> b.getMaterial() == material).findFirst().orElse(null); | |||
There was a problem hiding this comment.
Using a normal for loop instead of streams is preferred for slightly better performance, especially since this method could be called frequently.
| if (!node.check(player)) { | ||
| event.setCancelled(true); | ||
| String message = node.getDenyMessage(); | ||
| if(!message.isEmpty()) player.sendMessage(message); |
| boolean allowPlace = blockNode.node("allow_place").getBoolean(); | ||
| boolean allowBreak = blockNode.node("allow_break").getBoolean(); | ||
| List<? extends ConfigurationNode> requirementNodes = blockNode.node("requirements").childrenList(); | ||
| LinkedList<RequirementNode> nodes = new LinkedList<>(); |
There was a problem hiding this comment.
Use an ArrayList instead of LinkedList
In this PR, I added AuraSkillsLevelRestricts functionality to the main plugin.
See this config example:
It essentially allows setting requirements for blocks to be broken as well as placed, with the options for: skill levels, permissions, excluded worlds and stat levels