Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate proxyExists #67

Open
cckelly opened this issue Sep 27, 2018 · 0 comments
Open

Deprecate proxyExists #67

cckelly opened this issue Sep 27, 2018 · 0 comments
Assignees

Comments

@cckelly
Copy link
Contributor

cckelly commented Sep 27, 2018

The proxyExists function internally calls getProxyAddress and returns a boolean, so everywhere we need to call getProxyAddress, we also need to call proxyExists before it, introducing overhead and a potential gotcha.

This issue proposes deprecating the proxyExists method and modifying the getProxyAddress function to just throw an Error if the requested proxy doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant