Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proxyExists from ara-contracts #88

Closed
wants to merge 2 commits into from
Closed

Remove proxyExists from ara-contracts #88

wants to merge 2 commits into from

Conversation

cckelly
Copy link
Contributor

@cckelly cckelly commented Oct 23, 2018 •
edited
Loading

Fixes #67

@cckelly cckelly requested review from mahjiang and removed request for mahjiang October 23, 2018 22:33
@mahjiang mahjiang self-requested a review October 25, 2018 21:54
mahjiang
mahjiang suggested changes Oct 30, 2018
View reviewed changes
Copy link

@mahjiang mahjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, otherwise looks good!

registry.js
@@ -430,7 +428,6 @@ async function deployNewStandard(opts) {
}

module.exports = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we deprecate proxyExists? it looks like deprecate was required but not used

@vipyne
Copy link
Contributor

vipyne commented Jan 16, 2019

spoke offline, tabling this for now. may revisit in the future.

@vipyne vipyne closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahjiang mahjiang mahjiang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cckelly @vipyne @mahjiang