Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(task-services): Add task related queries and mutations #41

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

jatinriverlane
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
pyaqueduct
   api.py51492%194–197, 225–235
   experiment.py56198%93
   task.py46980%54–64, 69, 74, 79, 84, 89, 93–94
pyaqueduct/client
   client.py1594770%57–63, 113–118, 254–262, 331–339, 382–383, 420–421, 435–440, 479–484, 505–508, 533–551, 559–567
   experiment_types.py39197%20
   extension_types.py40295%30, 107
   task_types.py35391%31, 62, 96
TOTAL4986787% 

Tests Skipped Failures Errors Time
25 0 💤 0 ❌ 0 🔥 1.396s ⏱️

@jatinriverlane jatinriverlane changed the title add mutation for cancel task feat(task-services): Add task related queries and mutations Sep 30, 2024
@jatinriverlane jatinriverlane marked this pull request as ready for review October 4, 2024 14:42
Copy link
Contributor

@str-anger str-anger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Some technical changes requested.

pyaqueduct/api.py Outdated Show resolved Hide resolved
pyaqueduct/api.py Outdated Show resolved Hide resolved
pyaqueduct/api.py Show resolved Hide resolved
return [
Task(
client=self._client,
task_id=task.task_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class Task has no task_id field. But TaskData has. Can you resolve this please?

pyaqueduct/api.py Show resolved Hide resolved
pyaqueduct/client/client.py Outdated Show resolved Hide resolved
pyaqueduct/client/extension_types.py Show resolved Hide resolved
pyaqueduct/client/task_types.py Show resolved Hide resolved
pyaqueduct/extensions.py Outdated Show resolved Hide resolved
pyaqueduct/task.py Show resolved Hide resolved
@jatinriverlane jatinriverlane force-pushed the feat/TT-139-Task-Related-Services branch from d42b699 to ba5946e Compare October 9, 2024 15:12
@jatinriverlane jatinriverlane merged commit c6c8026 into main Oct 18, 2024
17 checks passed
@jatinriverlane jatinriverlane deleted the feat/TT-139-Task-Related-Services branch October 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants