Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix usei18n example. #128

Merged
merged 1 commit into from
Aug 7, 2023
Merged

docs: Fix usei18n example. #128

merged 1 commit into from
Aug 7, 2023

Conversation

jakubnowicki
Copy link
Member

closes #127

Copy link
Member

@DeepanshKhurana DeepanshKhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, quick fix! 💯 Approved ✅

@@ -41,7 +41,7 @@ i18n_state <- function(init_language) {
#'
#' server <- shinyServer(function(input, output, session) {
#' observeEvent(input$go,{
#' update_lang(session, "pl")
#' update_lang("pl")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to remove session altogether from this call since the default param should work on most cases anyway!

@jakubnowicki jakubnowicki merged commit c008668 into main Aug 7, 2023
6 checks passed
@jakubnowicki jakubnowicki deleted the fix-usei18n-example branch August 7, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: documentation error for function usei18n
2 participants