Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a unit test on windows CI #21

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fix a unit test on windows CI #21

merged 2 commits into from
Sep 10, 2024

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Sep 10, 2024 •
edited
Loading

Issue #20

Description

  • Fix a unit test on windows CI

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

jakubnowicki
jakubnowicki approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radbasa radbasa changed the title skip a unit test on windows Fix a unit test on windows CI Sep 10, 2024
@radbasa radbasa merged commit 389ef84 into main Sep 10, 2024
5 checks passed
@radbasa radbasa deleted the bugfix/cran-check-windows-error branch September 10, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubnowicki jakubnowicki jakubnowicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radbasa @jakubnowicki