Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsickle and typescript #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

DreierF
Copy link

@DreierF DreierF commented Jan 11, 2020

Hi,

I had to fix various issues that appeared after updating the loader to the latest tsickle version.

  • The output of tsickle is no longer goog.forwardDeclare but goog.requireType
  • The validateOptions was (no longer) correct (uses the typings shipped with schema-utils now)
  • emitWithTsickle has been deprecated in favor or emit
  • tsconfig.json did not allow relative path's for e.g. outDir
  • Arguments of the write callback have changed

Let me know if you have any questions :)

codedhead added a commit to codedhead/tsickle-loader that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant