Add the @avaialble directive to restrict the code being able to execute only under iOS 13 and above and add Authorization support. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add restriction in code to avoid compile time error during package consumer build.
Add authorization support for upload requests
olegbraginontarget
changed the title
Add authorization support
MOBN-562: iOS: Implement logging with ELK cluster support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of the PR
Enhance restriction of supported iOS version 13 and above in code. And allow proving the http requests with authorisation header.
♻️ Current situation
The package lacks the @avaialble directive and doesn't built under Xcode 14 and authorisation support
💡 Proposed solution
Added the @available(iOS 13, *) for the whole LogstashLogHandler struct.
Added Authorizable protocol and a default structure implementing it, so that http request for uploading the logs can use authorisation.
Testing
Test for @avaialble directive were not changed, since it was only a compile time issue.
Test for Authorisation support are not added, since it requires more work, because current tests are not emulating the upload process itself. Tests for that are coming soon.
Reviewer Nudging
From the beginning.