add ForemanApi

[evgeni]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 91.81818% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.03%. Comparing base (871cd13) to head (c8817e6).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
apypie/foreman.py	91.66%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   90.86%   91.03%   +0.17%     
==========================================
  Files           9       10       +1     
  Lines         449      558     +109     
==========================================
+ Hits          408      508     +100     
- Misses         41       50       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekohl]

Partial review, but the train just arrived

[ekohl]

I think my comments are mostly stylistic and overall 👍

Have you thought about documentation? I think we need to add it to https://github.com/Apipie/apypie/blob/master/docs/api.rst for it to be picked up.

[ekohl]

Nit: foreman_api?

[evgeni]

Nope :/

apypie/tests/conftest.py

Lines 44 to 49 in c77abe1

	@pytest.fixture
	def foreman_api(fixture_dir, requests_mock, tmpdir):
	with fixture_dir.join('foreman.json').open() as read_file:
	data = json.load(read_file)
	requests_mock.get('https://foreman.example.com/apidoc/v2.json', json=data)
	return apypie.Api(uri='https://foreman.example.com', api_version=2, apidoc_cache_dir=tmpdir.strpath)

[ekohl]

Nit: luna_api?

[evgeni]

Nope :/

apypie/tests/conftest.py

Lines 52 to 57 in c77abe1

	@pytest.fixture
	def luna_api(fixture_dir, requests_mock, tmpdir):
	with fixture_dir.join('luna.json').open() as read_file:
	data = json.load(read_file)
	requests_mock.get('https://foreman.example.com/apidoc/v2.json', json=data)
	return apypie.Api(uri='https://foreman.example.com', api_version=2, apidoc_cache_dir=tmpdir.strpath)

[evgeni]

applied your suggestions and added to docs (we don't have docs-build in CI, 😱)