Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint 8.20.0 → 8.21.0 (minor) #102

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 21, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ typescript-eslint (8.20.0 → 8.21.0)

Sorry, we couldn't find anything useful about this release.

↗️ @​typescript-eslint/eslint-plugin (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ @​typescript-eslint/parser (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Release Notes

8.21.0

8.21.0 (2025-01-20)

🚀 Features

  • ast-spec: support import attributes in TSImportType (#10640)

🩹 Fixes

  • eslint-plugin: [no-unnecessary-type-arguments] handle type args on jsx (#10630)
  • eslint-plugin: check JSX spread elements for misused spread usage (#10653)
  • eslint-plugin: [no-for-in-array] report on any type which may be an array or array-like (#10535)
  • eslint-plugin: [no-base-to-string] don't crash for recursive array or tuple types (#10633)
  • eslint-plugin: [no-duplicate-enum-values] handle template literal (#10675)
  • eslint-plugin-internal: [debug-namespace] on windows (#10661)
  • rule-tester: handle window root path (#10654)
  • scope-manager: add a reference for JSX closing element if it exists (#10614)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ @​typescript-eslint/scope-manager (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ @​typescript-eslint/types (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Release Notes

8.21.0

8.21.0 (2025-01-20)

🚀 Features

  • ast-spec: support import attributes in TSImportType (#10640)

🩹 Fixes

  • eslint-plugin: [no-unnecessary-type-arguments] handle type args on jsx (#10630)
  • eslint-plugin: check JSX spread elements for misused spread usage (#10653)
  • eslint-plugin: [no-for-in-array] report on any type which may be an array or array-like (#10535)
  • eslint-plugin: [no-base-to-string] don't crash for recursive array or tuple types (#10633)
  • eslint-plugin: [no-duplicate-enum-values] handle template literal (#10675)
  • eslint-plugin-internal: [debug-namespace] on windows (#10661)
  • rule-tester: handle window root path (#10654)
  • scope-manager: add a reference for JSX closing element if it exists (#10614)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ @​typescript-eslint/typescript-estree (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ @​typescript-eslint/utils (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Release Notes

8.21.0

8.21.0 (2025-01-20)

🚀 Features

  • ast-spec: support import attributes in TSImportType (#10640)

🩹 Fixes

  • eslint-plugin: [no-unnecessary-type-arguments] handle type args on jsx (#10630)
  • eslint-plugin: check JSX spread elements for misused spread usage (#10653)
  • eslint-plugin: [no-for-in-array] report on any type which may be an array or array-like (#10535)
  • eslint-plugin: [no-base-to-string] don't crash for recursive array or tuple types (#10633)
  • eslint-plugin: [no-duplicate-enum-values] handle template literal (#10675)
  • eslint-plugin-internal: [debug-namespace] on windows (#10661)
  • rule-tester: handle window root path (#10654)
  • scope-manager: add a reference for JSX closing element if it exists (#10614)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

↗️ @​typescript-eslint/visitor-keys (indirect, 8.20.0 → 8.21.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 21 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Summary by Sourcery

Update typescript-eslint to 8.21.0.

New Features:

  • Add support for import attributes in TSImportType.

Bug Fixes:

  • Fix a crash with recursive array or tuple types in the "no-base-to-string" rule.
  • Fix checking JSX spread elements for misused spread usage.
  • Fix the "no-for-in-array" rule to correctly report on any type which may be an array or array-like.
  • Fix the "no-duplicate-enum-values" rule to handle template literals.
  • Fix the "no-unnecessary-type-arguments" rule to handle type arguments on JSX.
  • Fix handling of window root path in the rule tester.
  • Fix debug namespace on Windows

Tests:

  • Adjust tests to verify that the "no-unnecessary-type-assertion" rule does not report template literals with expressions.

Description by Korbit AI

What change is being made?

Update typescript-eslint dependency version from 8.20.0 to 8.21.0 in package.json.

Why are these changes being made?

This update incorporates the latest features, improvements, and bug fixes provided in typescript-eslint version 8.21.0, ensuring the codebase remains current with the latest tooling standards. This helps maintainers avoid potential issues that might arise from using outdated versions.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@depfu depfu bot added the depfu label Jan 21, 2025
Copy link

korbit-ai bot commented Jan 21, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

The files' contents are under analysis for test generation.

Copy link
Contributor

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request updates the typescript-eslint package from version 8.20.0 to 8.21.0. This includes updates to several sub-packages such as @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and others. The primary goal of this update is to incorporate bug fixes and new features from the typescript-eslint project.

Class diagram showing typescript-eslint package update

classDiagram
    class TypescriptESLint {
        version: 8.21.0
    }

    TypescriptESLint *-- ESLintPlugin
    TypescriptESLint *-- Parser
    TypescriptESLint *-- ScopeManager
    TypescriptESLint *-- Utils
    TypescriptESLint *-- VisitorKeys
    TypescriptESLint *-- TypescriptESTree

    class ESLintPlugin {
        +handleJSXSpreadElements()
        +handleTypeArgsOnJSX()
        +handleTemplateLiteral()
    }

    class Parser {
        +supportImportAttributes()
    }

    class ScopeManager {
        +addJSXClosingElementReference()
    }

    note for ESLintPlugin "Fixed JSX spread elements,
type arguments, and template
literal handling"
Loading

File-Level Changes

Change Details Files
Updated typescript-eslint and its sub-packages to version 8.21.0.
  • Updated the typescript-eslint package version in package.json.
  • Updated the typescript-eslint package and sub-package versions in package-lock.json.
package.json
package-lock.json
Add support for import attributes in TSImportType.
  • This feature introduces support for import attributes in TSImportType within the AST specification.
Fixes and improvements to various eslint rules.
  • The no-unnecessary-type-assertion rule was adjusted to not report template literals with expressions.
  • The no-duplicate-enum-values rule was fixed to handle template literals.
  • The no-base-to-string rule was fixed to prevent crashes with recursive array or tuple types.
  • The no-for-in-array rule was fixed to report on any type that may be an array or array-like.
  • The no-unnecessary-type-arguments rule was fixed to handle type arguments on JSX.
  • JSX spread elements are now checked for misused spread usage.
Internal and tooling improvements.
  • The rule-tester was fixed to handle window root paths.
  • The scope-manager was updated to add a reference for JSX closing elements.
  • The debug-namespace was fixed for windows.
  • Dependencies such as knip, @microsoft/api-extractor, @babel/eslint-parser, stylelint, and eslint were updated.
  • Documentation was updated to use consistent verbiage around authoring pull requests.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Jan 21, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, depfu[bot]!). We assume it knows what it's doing!

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@guibranco guibranco enabled auto-merge (squash) January 21, 2025 18:56
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, filesystem +40 8.01 MB jameshenry

View full report↗︎

@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Jan 21, 2025
@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Jan 21, 2025
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@guibranco
Copy link
Member

@depfu merge

Copy link

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
A new release of infisical is available: 0.33.1 -> infisical/v0.104.0-postgres

To update, run: sudo apt-get update && sudo apt-get install infisical

6:56PM INF scanning for exposed secrets...
6:56PM INF 85 commits scanned.
6:56PM INF scan completed in 107ms
6:56PM INF no leaks found

@guibranco guibranco merged commit 698528b into main Jan 21, 2025
22 checks passed
@guibranco guibranco deleted the depfu/update/npm/typescript-eslint-8.21.0 branch January 21, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations depfu size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant