Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD and lock file improvements #30

Merged
merged 4 commits into from
Oct 21, 2024
Merged

BUILD and lock file improvements #30

merged 4 commits into from
Oct 21, 2024

Conversation

michael-sbarra-apexai
Copy link
Contributor

Closes #28

@michael-sbarra-apexai
Copy link
Contributor Author

michael-sbarra-apexai commented Oct 21, 2024 •
edited
Loading

@kilian-funk @evan-flynn-apexai Items 1 and 2 from #28 are implemented. Not yet implemented is the checker rule, to ensure the IN file hasn't been modified without an update to the lock file.

Update, latest push, test checker business logic implemented. Just need to un-hardcode the humble lockfile as the arg/data to the sh_test: #30 (comment)

@michael-sbarra-apexai michael-sbarra-apexai force-pushed the 28-BUILD-lock-file-improvements branch from c84fe16 to 9cf52af Compare October 21, 2024 19:27
michael-sbarra-apexai
michael-sbarra-apexai commented Oct 21, 2024
View reviewed changes
repos/config/detail/BUILD.bazel Outdated
name = "test_repos_index_sha256",
srcs = ["test/test_repos_index_sha256.sh"],
args = [
"$(execpath @rules_ros//repos/config:setup_humble.lock.bzl)", # TODO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just need to swap this out with the current Workspace lock file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"$(execpath @rules_ros//repos/config:setup_humble.lock.bzl)", # TODO
"$(execpath {})".format(REPOS_INDEX_FILE),

@michael-sbarra-apexai michael-sbarra-apexai force-pushed the 28-BUILD-lock-file-improvements branch from 9cf52af to 139929d Compare October 21, 2024 19:56
@michael-sbarra-apexai
Copy link
Contributor Author

@evan-flynn-apexai @kilian-funk This MR is ready.

@michael-sbarra-apexai michael-sbarra-apexai force-pushed the 28-BUILD-lock-file-improvements branch from 139929d to 8d972eb Compare October 21, 2024 20:09
@michael-sbarra-apexai
Copy link
Contributor Author

@evan-flynn-apexai CI was failing to start because run doesn't accept a list. I fixed in the latest push, and added explicit testing of the two packages that are able to be tested in this repo.

@michael-sbarra-apexai michael-sbarra-apexai merged commit 4ce8647 into main Oct 21, 2024
2 checks passed
@michael-sbarra-apexai michael-sbarra-apexai deleted the 28-BUILD-lock-file-improvements branch October 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-flynn-apexai evan-flynn-apexai evan-flynn-apexai approved these changes

@kilian-funk kilian-funk Awaiting requested review from kilian-funk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUILD and lock file improvements
2 participants
@michael-sbarra-apexai @evan-flynn-apexai