Merge pull request #2 from iamdefinitelyahuman/develop

better verbosity when building from source fails, bump version to 0.1.1

.gitignore

@@ -7,7 +7,7 @@ bin
 *.so
 
 # Packages
-*.egg
+*.eggs
 *.egg-info
 dist
 build

CHANGELOG

@@ -1,3 +1,8 @@
+0.1.1
+-----
+
+ - Better verbosity when building from source fails
+
 0.1.0
 -----
 

setup.py

@@ -8,7 +8,7 @@
 
 setup(
     name='py-solc-x',
-    version='0.1.0',
+    version='0.1.1',
     description="""Python wrapper around the solc binary with 0.5.x support""",
     long_description_markdown_filename='README.md',
     author='Benjamin Hauser (forked from py-solc by Piper Merriam)',

solcx/install.py

@@ -149,11 +149,20 @@ def _install_solc_osx(version):
     original_path = os.getcwd()
     os.mkdir(source_folder+'/build') 
     os.chdir(source_folder+'/build')
-    _check_subprocess_call(["cmake", ".."], message="Running cmake")
-    _check_subprocess_call(["make"], message="Running make")
-    os.chdir(original_path)
-    os.rename(source_folder+'/build/solc/solc', binary_path)
-    shutil.rmtree(source_folder)
+    try:
+        for cmd in (["cmake", ".."], ["make"]):
+            _check_subprocess_call(cmd, message="Running {}".format(cmd[0]))
+        os.chdir(original_path)
+        os.rename(source_folder+'/build/solc/solc', binary_path)
+    except subprocess.CalledProcessError as e:
+        raise OSError(
+            "{} returned non-zero exit status {}".format(cmd[0], e.returncode) +
+            " while attempting to build solc from the source. This is likely " +
+            "due to a missing or incorrect version of an external dependency."
+        )
+    finally:
+        os.chdir(original_path)
+        shutil.rmtree(source_folder)
 
     _chmod_plus_x(binary_path)