fix: cache .get_code()
#2480
Merged
fix: cache .get_code()
#2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/delete-unneeded-get-code
branch
from
0b23dcb to
706350e
Compare
fubuloubu
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Caches code, which is easier to do now that selfdestructs don't matter.
So there are a couples times when not to cache however such as during dev because of chain isolation and also when specifying
block_id=because you likely are checking for contract creation at a certain time.caching happens at the chain manager level, which is a familiar pattern.
The provider always checks the RPC, as should be its job.
fixes: #482
How I did it
How to verify it
Checklist