Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for ape 0.7, silverback 0.3, and pydantic 2 #91

Closed
wants to merge 5 commits into from
Closed

feat: support for ape 0.7, silverback 0.3, and pydantic 2 #91

wants to merge 5 commits into from

Conversation

mikeshultz
Copy link
Contributor

Upgrades Ape, Silverback, Pydantic. Fixes some other type issues.

@mikeshultz mikeshultz added the enhancement New feature or request label Jan 5, 2024
@mikeshultz mikeshultz requested a review from fubuloubu January 5, 2024 23:44
@mikeshultz mikeshultz self-assigned this Jan 5, 2024
@mikeshultz
Copy link
Contributor Author

Merging this might have unknown impact. Everything is pointed at this repo's main branch and we haven't done a release since September. So anything based on ape<0.7 may break.

Could drag our feet and point things at this branch? Though once the branch gets deleted then that all gets broken too. Suggestions?

@mikeshultz
Copy link
Contributor Author

Yeah, I think this branch needs to live for a little while. So either we don't merge this PR or don't delete the branch if we do (not sure if auto in this repo).

@antazoey
Copy link
Member

Can we merge this?
I can then update to 0.8.
I need to test some Ape features on this project...

@fubuloubu
Copy link
Member

Can we merge this?
I can then update to 0.8.
I need to test some Ape features on this project...

Its old enough you are probably better off doing the upgrade in this PR to see if the updates still work

And yes, i nees this soon too haha

@antazoey
Copy link
Member

actually #97

@fubuloubu
Copy link
Member

closed in favor of #97

@fubuloubu fubuloubu closed this Aug 28, 2024
@fubuloubu fubuloubu deleted the feat/apeup branch August 28, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees

@mikeshultz mikeshultz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeshultz @antazoey @fubuloubu