This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[chore] Resolve EIP feedback #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elliott-Green
changed the title
DeFiFoFum
suggested changes
Aug 28, 2023
There was a problem hiding this comment.
Thanks @Elliott-Green for putting this together.
I added one comment, please resolve that and then I will merge. 🙏
|
I notice that the IERC5725 function ordering change isn't present on the EIP fixes you've made. |
I decided to follow a similar ordering pattern as ERC-721 and changed the linter ordering from |
DeFiFoFum
approved these changes
Aug 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves all of the comments made in the feedback on the EIP PR.
@DeFiFoFum I don't understand how the files are still being reverted. Need to make sure we're fetching the latest from master after merging.