Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size presets for Windowed mode #339

Open
JoshLillis opened this issue Apr 30, 2020 · 18 comments
Open

Size presets for Windowed mode #339

JoshLillis opened this issue Apr 30, 2020 · 18 comments
Labels
enhancement New feature or request

Comments

@JoshLillis
Copy link

JoshLillis commented Apr 30, 2020 •
edited
Loading

The new Windowed mode in 1.6.0.3 has been very helpful for use in Zoom--THANK YOU.
Setting the Zoom screenshare to the OnlyM Media Window works well since it has no window decorations/borders and makes it easier to shrink the screenshare to a lower resolution to improve the clarity and performance of the video going out to the Zoom participants.

However, that works best when the size of media window matches the resolution/aspect ratio of the videos being played (especially when the user's computer is older and/or bandwidth is limited).
I was able to manually resize it to the specific resolution needed, but it was a bit of work (thankfully it saves the dimensions).
It would be helpful if there were some preset size selections for that media window, such as what mirrors the JW videos:

  • 720p (1280x720)
  • 480p (960x540)
  • 360p (640x360)
  • Custom (manual resizing)

Perhaps if the "Windows" option is checked, a menu would be available next to or below that checkbox with the above selections (including the text in parentheses), and the Custom option would just be the current mode that allows manual resizing.

If possible, the OnlyM media window would retain the specified dimensions even if the monitor resolution was changed (primarily a benefit for virtual machine users). Unsure if operating systems allow this with a resolution change.

Thanks for considering.
@richfrantz
Copy link

richfrantz commented Apr 30, 2020 via email

@JoshLillis
Copy link
Author

Forgot to mention another benefit to this is for those using virtual computers/machines (great for those with limited/unstable internet or older computers) to push video over Zoom.
In case the user accidentally resizes the virtual machine window, the OnlyM media window would either not be resized (if possible to extend beyond the monitor boundaries) or would at least allow for quick recovery to the desired dimensions.

@timjobutler
Copy link

@AntonyCorbett If this feature is not burdensome to implement, this would be an excellent enhancement

@jarednlivingston
Copy link

Forgot to mention another benefit to this is for those using virtual computers/machines (great for those with limited/unstable internet or older computers) to push video over Zoom.

Have you found a VM that works well for this? I have a fairly robust Azure VM that I tried using, but the video was choppy. I figured it was due to a lack of a specialized video card.

@JoshLillis
Copy link
Author

JoshLillis commented May 9, 2020 via email

@jarednlivingston
Copy link

jarednlivingston commented May 9, 2020 via email

@JoshLillis
Copy link
Author

JoshLillis commented May 13, 2020 via email

@AntonyCorbett
Copy link
Owner

@JoshLillis Hi Josh. Can I suggest you create a gist on github and then just post a link to it? This will make it easier for you to direct others to it and also to keep it updated. Thanks, Antony

@JoshLillis
Copy link
Author

Thank you, Antony. Here's the link:
https://gist.github.com/JoshLillis/b08803ac6e2246c78d963a02b2fff0a7

@AntonyCorbett AntonyCorbett added the enhancement New feature or request label Jun 14, 2020
@zokradonh
Copy link

Why size presets at all? It should be possible to resize the window automatically to the media resolution. Whatever the resolution is (except exceeding ones).

Any drawbacks of such a solution?

  • Transition effects would be a problem here.

My tests today with experimental code changes are working.

@zokradonh zokradonh mentioned this issue Mar 24, 2021
Closed
4 tasks
@JoshLillis
Copy link
Author

JoshLillis commented Mar 24, 2021 via email

@zokradonh
Copy link

A few drawbacks I see: If you happen to have media that is larger resolution than you want to push through Zoom, quality could suffer. For example, if the media you have is 720p resolution, but you only have the bandwidth to smoothly push 480p videos, the quality could suffer.

You are right. There is a need to limit it.

What I've seen before in my Zoom testing over limited bandwidth. If the media is larger resolution than your free screen space, it will cause other windows to overlap the media window and cover your content in the screen share.

What do you mean with "free screen space"? As long as the media window is in front, no other windows will interfere with screen share. You can also activate "Always top most"(don't know the english translation of the OnlyM option) then you do not have any problem here. Or did I miss something here?

If the various media is a variety of different resolutions, the window size will vary with each item, giving an unpredictable user experience. The presets would ensure a more consistent user experience, and give the user more control over the quality of what the recipients see in the screen share.

If you fix the window size to 720p or 480p then you always transmit 16:9 images. Not all Zoom end user devices use that kind of resolution. Maybe they also have portrait mode which would suffer then. Streaming a quadratic image as 720p would add black borders to left and right and to end users in portrait mode would result in black borders left, right, top and bottom, making the image very small.
Streaming only the with correct aspect ratio is in my opinion the best streaming "quality".

Maybe the best option here would be to implement a maximum width and maximum height setting. But keep aspect ratio. So you do not have unpredictable big images and suffered user experience. What do you think about that?

@JoshLillis
Copy link
Author

JoshLillis commented Mar 25, 2021 via email

@peter-altherr
Copy link

peter-altherr commented Jun 24, 2021 •
edited
Loading

i would be very happy to see the proposed enhancements having a few options for windowed mode as described in JoshLillis very first post above :-) until today our congregations audio/video team has been dealing with vlc media player for both images and videos which works quite good in the background and provides a smooth user experience. worst case is having several images within a talk in different dimensions and the requirement to show them in a fast sequence. as the occupied screen area has to be redrawn everytime the image dimension changes the zoom client is forced to quit the screen share. my guess this would happen the same, if onlym starts dynamically adjusting the screen area size acoording the presented media size.

@zokradonh: you are right with your concerns about the different media formats to be presented and even more device configurations at the end users site. my opinion: this issue is not feasable (by us) in a way all users will be satisfied and perfectly feed up according their local device configuration. i would focus on the media aspect, size and orientation we mostly use: 16:9, 720p, landscape. this should be communicated to all user together with the recommendation to change their setup accordingly or if unable to do so, we gently provide assistance to those.

greetings from germanys black forrest
peter

@zokradonh
Copy link

my guess this would happen the same, if onlym starts dynamically adjusting the screen area size acoording the presented media size.

VLC creates a new Win32 window handle for each new media (with new dimensions?). That is the reason why Zoom needs to restart screen share. OnlyM does not recreate the window. Zoom has no problems with window resizing and adjusts automatically. So resizing would not be a problem.

Also I think the case I mentioned is just an edge case. Most of the Zoom Clients will use something like 16:9. It just feels bad for me to stream black border areas.

But I understand that many OnlyM users like to have a static size to easily manage the windows. I had not yet time to further develop a solution that solves both problems.

greetings back from northern germany ;)

@zokradonh
Copy link

I just noticed, that Antony is working on a .NET 5 port of OnlyM. Then I should wait with any further development until this port is released.

@drothmaler drothmaler mentioned this issue Aug 3, 2021
Merged
@drothmaler
Copy link
Contributor

drothmaler commented Aug 4, 2021 •
edited
Loading

As you can see in the PR, linked above, I took the time to implement a Size-Preset feature for OnlyM - feel free to check it out if you want.

@drothmaler
Copy link
Contributor

I also had a look at the PR from @zokradonh and tried to integrate that too.

Unfortunately there are a few issues with the auto-sizing process... So before spending more time on that, I'd like to gather the actual interest on the Auto-Resize feature - because personally wouldn't like it, if the windows jumps around and most of the videos / pictures we use, are 720p anyway.

So could you all please add a thumbs up 👍 or thumbs down 👎 to this post, to indicate, if you actually need Auto-Resizing, or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New: Resize window on new media zokradonh/OnlyM
8 participants
@drothmaler @zokradonh @AntonyCorbett @jarednlivingston @richfrantz @timjobutler @JoshLillis @peter-altherr