Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python >= 3.8 #33

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Support Python >= 3.8 #33

wants to merge 6 commits into from

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 1, 2024 •
edited
Loading

Because why not?

@AntonLydike AntonLydike marked this pull request as ready for review August 1, 2024 10:03
@AntonLydike
Copy link
Owner

😱

@PapyChacal PapyChacal changed the title [WIP] Support Python >= 3.8 Support Python >= 3.8 Aug 1, 2024
@PapyChacal
Copy link
Collaborator Author

pre-commit is requiring Python>=3.9, which now completely blocks poetry to agree on stating the project is compatible with Python >= 3.8, which feels weird because, nobody needs pre-commit to just use filecheck?

@AntonLydike
Copy link
Owner

Hmmm, interesting point. I guess if you can't develop the project on 3.8, then is it really compatible with 3.8?

@AntonLydike
Copy link
Owner

Have you tried running poetry lock --no-update? This will re-solve the dependencies and might fix the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PapyChacal @AntonLydike