Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter prefix matching (fixes #28) #29

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

AntonLydike
Copy link
Owner

@AntonLydike AntonLydike commented Jul 30, 2024

This PR adds the requirement that the CHECK be preceded by either a new-line, or a character that is not [A-Za-z]. This fixes #28

It also adds diagnostic printing when checking fails inside a DAG region by printing all currently considered input and greying out regions that are already consumed.

@AntonLydike AntonLydike added bug Something isn't working parity Diverging from upstream FileCheck labels Jul 30, 2024
@AntonLydike AntonLydike merged commit ee8526c into main Jul 30, 2024
4 checks passed
@AntonLydike AntonLydike deleted the anton/proper-prefix-checking branch July 30, 2024 12:15
AntonLydike added a commit that referenced this pull request Jul 30, 2024
This PR fixes #27 

It also contains a small additonal fix for #29, where `_` and `-` are
also not allowed before a check prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parity Diverging from upstream FileCheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check-prefix being a suffix of other check-prefixes in the same file
1 participant