regex: Fix negative sets capturing newlines #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVMs
llvm::Regex
has the following flag enabled on all FileCheck regex matches:This means that
[^ ,]
, combined with this flag, is actually equivalent to[^\n ,]
in python. Since python doesn't have a flag like this, we approximate this through a best-effort patch that tries to add\n
to negative sets in the regexes as part of the regex translation.This is not a good fix imho, as it will break on regexes where
[^
appears inside a set, but that should be sufficiently rare that it won't happen 🤞