Remove unused visible_nodes hashes from api element controllers

AntonKhorev · Feb 1, 2025 · 8508c4f · 8508c4f
1 parent b8924ed
commit 8508c4f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/app/controllers/api/relations_controller.rb b/app/controllers/api/relations_controller.rb
@@ -102,14 +102,11 @@ def full
         node_ids += way_node_ids.flatten
         nodes = Node.where(:id => node_ids.uniq).includes(:node_tags)
 
-        visible_nodes = {}
-
         @nodes = []
         nodes.each do |node|
           next unless node.visible? # should be unnecessary if data is consistent.
 
           @nodes << node
-          visible_nodes[node.id] = node
         end
 
         @ways = []

diff --git a/app/controllers/api/ways_controller.rb b/app/controllers/api/ways_controller.rb
@@ -76,15 +76,10 @@ def full
       @way = Way.includes(:nodes => :node_tags).find(params[:id])
 
       if @way.visible
-        visible_nodes = {}
-
         @nodes = []
 
         @way.nodes.uniq.each do |node|
-          if node.visible
-            @nodes << node
-            visible_nodes[node.id] = node
-          end
+          @nodes << node if node.visible
         end
 
         # Render the result