Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.21.3/1.21.4 #399

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Update to 1.21.3/1.21.4 #399

wants to merge 9 commits into from

Conversation

Xtendera
Copy link

@Xtendera Xtendera commented Dec 22, 2024

Builds

Testing builds are now available.

Build 2 (1.21.4):
Some shaders in the rendering modules have restored functionality.
Artifact Download

Build 1 (1.21.3):
Artifact Dowload

Description

I am attempting to update this addon to 1.21.3. There is a lot of changes so bare with me while I attempt to fix everything.

Related Issue

#397

Motivation and Context

This project is a bit backlogged, I totally get it and I will try to lessen the work for maintainers.

How Has This Been Tested?

I will individually test some features once it starts working, but I will ask for other people's help to make sure everything works properly and will make changes as needed.

Roadmap (Not all changes may be committed yet, this is specifically for my own tracking)

  • Update Gradle and Dependencies
  • CenterCommand.java
  • KickCommand.java
  • InteractionScreen.java
  • GameRendererMixin.java
  • AntiCrash.java
  • ExtraElytra.java
  • PacketFly.java
  • ArrowDmg.java
  • AutoCraft.java
  • BoatPhase.java
  • ChorusExploit.java
  • CoordLogger.java
  • FullFlight.java
  • Jetpack.java
  • KnockbackPlus.java
  • NewChunks.java
  • Ore.java

⚠️Rendering.java (See below)

  • ShieldBypass.java

⚠️SkeletonESP.java (See below)

  • SoundLocator.java
  • GiveUtils.java
  • RejectUtils.java
  • WorldUtils.java

⚠️ Issues with SkeletonESP and Shaders

In Minecraft 1.21.2, Minecraft's rendering system was rewritten, breaking some of the code used in many modding projects, including this one. There is work being done to transition old code over to the new system, but it will take some time. For now, expect that some parts of the SkeletonESP Module and the Shaders feature of the Rendering module will be broken until further notice.

Don't expect it to work anytime soon.
@Xtendera
Copy link
Author

By the way, my changes for AutoCraft.java are quite weird, if someone could verify that it logically makes sense and lines up with previous logic that would be great.

Had to revert gradle to 8.10 due to unforseen issues.
@Mleczyk
Copy link

Mleczyk commented Dec 22, 2024

OMG U GOT IT ❤️❤️

@Xtendera
Copy link
Author

image
We're in boys.

On first glance everything seems to be working fine. Please lmk of any issue you encounter.

@Mleczyk
Copy link

Mleczyk commented Dec 22, 2024

ILYSM ❤️❤️

@crazymoose7
Copy link
Contributor

Without opening IDE
it seems line 47 in WorldUtils might be able to be replaced with : mc.player.setSneaking(false);
Rendering.java have you tried mc.getShaderLoader().loadPostEffect() and pass in the ID and DefaultFramebufferSet.STAGES ?

Willtest and take a look at autocraft soon.

@Mleczyk
Copy link

Mleczyk commented Dec 25, 2024

also AutoLogin wont save passwords after register with the create strong password option

@Xtendera
Copy link
Author

Without opening IDE it seems line 47 in WorldUtils might be able to be replaced with : mc.player.setSneaking(false); Rendering.java have you tried mc.getShaderLoader().loadPostEffect() and pass in the ID and DefaultFramebufferSet.STAGES ?

Willtest and take a look at autocraft soon.

I will also look into it soon. Yes line 47 of WorldUtils is overcomplicated lol. I have not tried the getShaderLoader thing, but I will see if that works hopefully today.

also AutoLogin wont save passwords after register with the create strong password option

Will also look into this 👍🏽

@Xtendera
Copy link
Author

@crazymoose7 Okay after some testing the loadPostEffect method does not seem to work in it's current state, it is causing a black screen on launch. I will attempt to move it around (maybe even by mixining some other methods that use it) to see if it could just be a placement thing. I also tried MAIN_ONLY and MAIN_AND_ENTITY_OUTLINE and neither work properly.

@crazymoose7
Copy link
Contributor

@Xtendera I think something worth noting is the different shaders in the shaders/post directory, while not directly connected to this issue. The current enum hasnt been updated to reflect changes.
Did the log output provide anything ?

@vanvac
Copy link

vanvac commented Jan 9, 2025

will this pr be migrated to 1.21.4 or finish the 1.21.3 update and then work on 1.21.4?

@Xtendera
Copy link
Author

Xtendera commented Jan 9, 2025

@Xtendera I think something worth noting is the different shaders in the shaders/post directory, while not directly connected to this issue. The current enum hasnt been updated to reflect changes. Did the log output provide anything ?

Sorry for the late response. Nope, the log output was completely clear, and it seemed that the on screen buttons also worked, just nothing was actually rendered.

will this pr be migrated to 1.21.4 or finish the 1.21.3 update and then work on 1.21.4?

1.21.4 is super easy I will work on that soon. It was the 1.21.2 update that really caused issues. Of course renderer and skeleton might still stay broken/

@areume669
Copy link

How do I download this??

@vanvac
Copy link

vanvac commented Jan 13, 2025

Not for 1.21.4 https://github.com/AntiCope/meteor-rejects/actions/runs/12456969030 download the artifact file from this github action and unzip for the 1.21.3 version please note the some render related things are broken due to changes with 1.21.2-3

@Xtendera Xtendera changed the title Update to 1.21.3 Update to 1.21.3/1.21.4 Jan 13, 2025
@fortune428
Copy link

fortune428 commented Jan 14, 2025

when loading the world,the game will crashes,I dont know the reason
game version is1.21.4

@crazymoose7
Copy link
Contributor

crazymoose7 commented Jan 14, 2025

progress

progress on the Rendering Module ! @Xtendera - Edit : PR for draft

might as well make this 1.21.4 and format version to the new addon version as well

@vanvac
Copy link

vanvac commented Jan 14, 2025

pretty sure its a Mixin crash
https://mclo.gs/5wmfGT1
happens when joining a world after it loads to 100%

@crazymoose7
Copy link
Contributor

crazymoose7 commented Jan 14, 2025

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.

Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well.
https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

crazymoose7 and others added 2 commits January 14, 2025 15:45
@Xtendera
Copy link
Author

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.

Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well. https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Awesome! I will be looking at SkeletonESP today to see whats going on there. It's actually just one line that I commented out that I need to figure out what it does. The module itself actually seems to work fine.

@crazymoose7
Copy link
Contributor

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.
Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well. https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Awesome! I will be looking at SkeletonESP today to see whats going on there. It's actually just one line that I commented out that I need to figure out what it does. The module itself actually seems to work fine.

I had removed the commented line after I believe it is not needed any more perhaps ? I had looked at examples of changes in some of minecrafts own Entities and the changes you made already seemed to be suitable. Let me know what you see !

@Xtendera
Copy link
Author

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.
Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well. https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Awesome! I will be looking at SkeletonESP today to see whats going on there. It's actually just one line that I commented out that I need to figure out what it does. The module itself actually seems to work fine.

I had removed the commented line after I believe it is not needed any more perhaps ? I had looked at examples of changes in some of minecrafts own Entities and the changes you made already seemed to be suitable. Let me know what you see !

After some digging, yeah, that line seems useless in SkeletonESP. This means that that module is now fixed and works okay.

There are still some things in Rendering that haven't been ported right? I will start working on those soon. LMK if you find anything relating to that.

@crazymoose7
Copy link
Contributor

@Xtendera I believed Rendering to be all set, what seems to be missing ? I can take another look later.

@RacoonDog
Copy link
Contributor

any updates on the state of this pull request?

@crazymoose7
Copy link
Contributor

any updates on the state of this pull request?

I believe it is done ! Have been using the build on my end without issues or any bugs.

@Xtendera Xtendera marked this pull request as ready for review January 21, 2025 01:30
@Xtendera
Copy link
Author

Sorry I was a bit busy. We are good to merge!

@RacoonDog
Copy link
Contributor

Sorry I was a bit busy. We are good to merge!

are the SkeletonESP and Rendering modules still broken?

@crazymoose7
Copy link
Contributor

Sorry I was a bit busy. We are good to merge!

are the SkeletonESP and Rendering modules still broken?

Nope ! They work

@RacoonDog
Copy link
Contributor

ideally i’d want SkeletonESP to use meteor 3d rendering methods but considering those dont support matrices i guess it can wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants