Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix start_block to return correct return code for incomplete apply_block #1028

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix start_block to return correct return code for incomplete apply_block #1028

wants to merge 3 commits into from

Conversation

heifner
Copy link
Member

@heifner heifner commented Nov 13, 2024 •
edited
Loading

start_block was returned failed instead of waiting_for_block when apply_block returned incomplete processing of blocks. This resulted in a warn log message and a reschedule of block production instead of just waiting for processing to complete.

Also fixed apply_block to not return incomplete for a block that takes more than 500ms to validate.

Resolves #1002

@heifner heifner added OCI Work exclusive to OCI team bug The product is not working as was intended. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
bug The product is not working as was intended. OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.1 Log: warn: Failed to start a pending block
3 participants
@heifner @greg7mdp @linh2931