-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ASAN CI "platform" #2347
add ASAN CI "platform" #2347
Conversation
set(CMAKE_CXX_FLAGS "-fsanitize=address -fno-omit-frame-pointer" CACHE STRING "") | ||
EOF | ||
|
||
ENV ASAN_OPTIONS=detect_leaks=0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some WAVM memory "leaks" that have been known about for 5+ years. It'd be nice to resolve them one day to reenable the leak test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to get NP or LR tests to complete in CI without either running out of memory or having some sort of timing problem. I even tried increasing the resources for the run but that still wasn't enough. I think it's likely worthwhile to go ahead with what we've got though as at least we'll still get unit test coverage, and reevaluate whatever the performance problem is later (I was able to complete them successfully locally).
Is this still true, looks like NP and LR tests are running.
I got a failure in Ubsan CI #2350 |
Not for I had tried in a different branch to give NP/LR asan more resources, for example by doing for NP, leap/.github/workflows/build.yaml Lines 178 to 184 in f1ded48
but plugin_http_api_test failed (doesn't locally) and it looks like a timing problem,https://github.com/AntelopeIO/leap/actions/runs/8430283230/job/23086076054 and for LR doing something similar such as leap/.github/workflows/build.yaml Lines 220 to 226 in f1ded48
but the box fell over running out of memory https://github.com/AntelopeIO/leap/actions/runs/8430283230/job/23086075824 maybe giving them even more resources would work. |
Note:start |
Adds a new "platform" that builds & tests the software with ASAN.
It's possible to enable a single build with UBSAN+ASAN simultaneously, but this further increases both the compile time and run time overhead. So do UBSAN & ASAN separately for now.
And speaking of ASAN build overhead, I was unable to get NP or LR tests to complete in CI without either running out of memory or having some sort of timing problem. I even tried increasing the resources for the run but that still wasn't enough. I think it's likely worthwhile to go ahead with what we've got though as at least we'll still get unit test coverage, and reevaluate whatever the performance problem is later (I was able to complete them successfully locally).
Example run of ASAN failures:
https://github.com/AntelopeIO/leap/actions/runs/8458172328/job/23172568986