Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add renewable clusters to API endpoints #1798

Merged
merged 10 commits into from
Nov 13, 2023
Merged

feat(api): add renewable clusters to API endpoints #1798

merged 10 commits into from
Nov 13, 2023

Conversation

hdinia
Copy link
Member

@hdinia hdinia commented Nov 7, 2023

fix #1792

@hdinia hdinia self-assigned this Nov 7, 2023
@commit-lint Commit Lint
Copy link

commit-lint bot commented Nov 7, 2023 •
edited
Loading

Features

  • api: add renewables clusters api endpoints (f9e9cfa)
  • api: add backport API endpoints for renewable cluster management (88a7cae)
  • variant: avoid removing binding constraints when a renewable cluster is removed (b9baeb1)

Chore

  • correct comment in unit test (4281adb)

Bug Fixes

  • command: ensure the area exist before apply renewable cluster deletion (f22517b)
  • pydantic: fix wrong pydantic models (274a165)

Tests

  • renewable: correct integration test of renewable clusters (fbbf7ce)
  • variants: correct integration test of renewable clusters (5198126)

Styles

  • renewable: correct code style (8a8fd76)

Documentation

  • variant: add a comment in CreateRenewablesCluster class about the renewable-generation-modelling checking (8a2ac6f)

Contributors

hdinia, laurent-laporte-pro, MartinBelthle

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@MartinBelthle
Copy link
Contributor

I'll wait for you to fix the lint and the tests so i can start the review :)

@hdinia hdinia requested review from laurent-laporte-pro and MartinBelthle and removed request for laurent-laporte-pro November 7, 2023 13:42
@hdinia hdinia force-pushed the feature/1792-add-renewables-api-endpoints branch 2 times, most recently from 7e52b82 to b11fd18 Compare November 10, 2023 07:41
@hdinia hdinia force-pushed the feature/1792-add-renewables-api-endpoints branch from b11fd18 to f9e9cfa Compare November 10, 2023 08:25
@laurent-laporte-pro laurent-laporte-pro changed the title feat(api): add renewables clusters api endpoints feat(api): add renewable clusters api endpoints Nov 10, 2023
@laurent-laporte-pro laurent-laporte-pro changed the title feat(api): add renewable clusters api endpoints feat(api): add renewable clusters API endpoints Nov 10, 2023
@laurent-laporte-pro laurent-laporte-pro changed the title feat(api): add renewable clusters API endpoints feat(api): add renewable clusters to API endpoints Nov 10, 2023
laurent-laporte-pro and others added 3 commits November 11, 2023 09:43
@laurent-laporte-pro
docs(variant): add a comment in CreateRenewablesCluster class about…
8a2ac6f 
… the `renewable-generation-modelling` checking
@laurent-laporte-pro
feat(variant): avoid removing binding constraints when a renewable cl…
b9baeb1 
…uster is removed

There is no binding constraint with renewable clusters, only with thermal clusters.
@MartinBelthle
fix(pydantic): fix wrong pydantic models
274a165
@hdinia hdinia merged commit a4bce7e into dev Nov 13, 2023
@hdinia hdinia deleted the feature/1792-add-renewables-api-endpoints branch November 13, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle approved these changes

Assignees

@hdinia hdinia

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ANT-706] Add renewables clusters API endpoints
3 participants
@hdinia @MartinBelthle @laurent-laporte-pro