Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding setuptools to release.py #1487

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adding setuptools to release.py #1487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2d2ce9
Update 18_release.ipynb
kimleeng Jan 17, 2025
20633ec
Update release.py
kimleeng Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nbdev/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def _get_conda_meta():
doc_url = (cfg.doc_host + cfg.doc_baseurl) if (cfg.doc_host and cfg.doc_baseurl) else url
dev_url = cfg.git_url if cfg.git_url else url

hostreqs = ['packaging', f'python >={cfg.min_python}']
hostreqs = ['setuptools', 'packaging', f'python >={cfg.min_python}']
reqs = hostreqs+[]
if cfg.get('requirements'): reqs += cfg.requirements.split()
if cfg.get('conda_requirements'): reqs += cfg.conda_requirements.split()
Expand Down
2 changes: 1 addition & 1 deletion nbs/api/18_release.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@
" doc_url = (cfg.doc_host + cfg.doc_baseurl) if (cfg.doc_host and cfg.doc_baseurl) else url\n",
" dev_url = cfg.git_url if cfg.git_url else url\n",
"\n",
" hostreqs = ['packaging', f'python >={cfg.min_python}']\n",
" hostreqs = ['setuptools', 'packaging', f'python >={cfg.min_python}']\n",
" reqs = hostreqs+[]\n",
" if cfg.get('requirements'): reqs += cfg.requirements.split()\n",
" if cfg.get('conda_requirements'): reqs += cfg.conda_requirements.split()\n",
Expand Down