Fix: Use default_factory for splits and make char fields optional in DatasetConstants #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, many users will utilize this script to experiment with their own datasets for training. However, the original DatasetConstants class had two main issues:
Changes
field(default_factory=dict)
, ensuring each DatasetConstants instance gets its own independent dictionary.chars_per_sample
andchars_per_token
to Optional[int] with default values of None, making these parameters optional and the script more flexible.This change is essential to avoid potential time waste for users who might otherwise encounter unexpected behavior when running the script on their own datasets.