Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 URL export as str #886

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix: 🐛 URL export as str #886

merged 2 commits into from
Jul 11, 2023

Conversation

Anselmoo
Copy link
Owner

All PR-Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open
    Pull Requests for the same
    update/change?

New ✨✨ Feature-Submissions:

Changes to ⚙️ Core-Features:

  • Have you added an explanation of what your changes do and why you'd like
    us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@Anselmoo
fix: 🐛 URL export as str
2ce6bb2 
Formally, HttpURL check was saving as object in the list and doesn't allow to export via toml. Now, URL validation is performed via `classmethod`
@Anselmoo
build: 🔖 v0.20.1
f633a0f
@Anselmoo Anselmoo enabled auto-merge (squash) July 11, 2023 17:51
@github-actions github-actions bot added testing Improve testing & coverage maintenance Maintenance & Security dependencies Pull requests that update a dependency file release Release labels Jul 11, 2023
@Anselmoo Anselmoo changed the title Anselmoo/issue885 fix: 🐛 URL export as str Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #886 (f633a0f) into main (b8d6b4e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #886   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         3635      3648   +13     
=========================================
+ Hits          3635      3648   +13
Impacted Files Coverage Δ
spectrafit/__init__.py 100.00% <100.00%> (ø)
spectrafit/api/cmd_model.py 100.00% <100.00%> (ø)
spectrafit/api/test/test_cmd_model.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 11, 2023
View reviewed changes
spectrafit/api/test/test_cmd_model.py Dismissed Show dismissed Hide dismissed
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Anselmoo Anselmoo merged commit ff6a48d into main Jul 11, 2023
28 of 29 checks passed
@Anselmoo Anselmoo deleted the Anselmoo/issue885 branch July 11, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance Maintenance & Security release Release testing Improve testing & coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a TypeError for passed URL
1 participant
@Anselmoo