(feature) Add captcha event hook #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
7 tasks
ghost
commented
Sep 29, 2019
| def cloudflare_is_bypassed(self, url, resp=None): | ||
| cookie_domain = ".{}".format(urlparse(url).netloc) | ||
| return ( | ||
| self.cookies.get("cf_clearance", None, domain=cookie_domain) or | ||
| (resp and resp.cookies.get("cf_clearance", None, domain=cookie_domain)) | ||
| ) | ||
|
|
||
| def handle_captcha_challenge(self, resp, url): |
There was a problem hiding this comment.
It doesn't really make sense to accept the url argument here and it's not documented but we might want to wait until the next major release to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://requests.kennethreitz.org/en/stable/user/advanced/#event-hooks