Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 1.7.10 repo: Fix for the latest Optifine version and Workspace update #1294

Open
wants to merge 3 commits into
base: 1.7.10
Choose a base branch
from

Conversation

HRudyPlayZ
Copy link

@HRudyPlayZ HRudyPlayZ commented Nov 2, 2021

Hey, i've managed with a massive help from makamys on Discord, to fix the incompatibility between The Betweenlands and newer 1.7.10 Optifine versions. I know 1.7.10 is pretty old and i understand that you might not want to spend time on it these days, but this fix finally lets 1.7.10 players to use shaders, especially since ShaderModCore doesn't work with current shaders anymore, alongside The Betweenlands without the game crashing at launch. Some people might still want to use the 1.7 version since mods such as Netherlicious, Eternal Frost and others never updated.

If you don't want to update this version officially, which i could understand, could you grant me the authorization to distribute the compiled binaries as releases on my fork?

- Switched from Java 7 to Java 8
- Updated to Forge 1614
- Added convenient settings for IntelliJ editors in the build.gradle
- Updated gradle wrapper from 2.8 to 4.41
- Updated gradlew files
-  Added the ClassWriter.COMPUTE_FRAMES flag to the transformEntityRenderer method.
- Added the getLocalVarIndex method to look for the correct index (necessary since Optifine changed them in E7)
- Changed the starting offset of the objectXYZ for loop to use the index of "var7" (or "d0" without Optifine)
- Replaced the static 14 index with the dynamic "var14" (or "frustrum") one inside the if checks.
- Spaced the code a little bit so it gets better to read (still isn't great)

HUGE THANKS TO MAKAMYS FOR HELPING ME ON THIS ONE!
(Forgot to push it alongside the previous commit)
@Rubendx25
Copy link

Please HRudyPlayZ, submit the fixed mod

@HRudyPlayZ
Copy link
Author

Please HRudyPlayZ, submit the fixed mod

I released it a while ago on my fork if you want :D

@Rubendx25
Copy link

Can you compile the project and post it?
or how can i use it?

@HRudyPlayZ
Copy link
Author

I already posted the release on Github here.
I cannot post it on Curseforge unless i get explicit authorisation by Angry-Pixel.
If you want to use it in a Curseforge modpack, i recommend using mods such as MCInstance Loader or ModDirector to include external mods, or in this case, forks.

@Exsolutus
Copy link

@HRudyPlayZ Is the player arm not following the camera anymore a known issue with this fork?

@HRudyPlayZ
Copy link
Author

HRudyPlayZ commented Jan 13, 2023

@HRudyPlayZ Is the player arm not following the camera anymore a known issue with this fork?

Sorry for answering almost a year late, Github never gave me a notification of this comment.
No, i didn't know of it, might look into it at some point, but it's probably gonna take a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants