Losslessly optimise file size of mod assets #1140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was achieved through using “Papa’s Best Optimizer” (which can be downloaded from https://papas-best.com/optimizer_en) with “Optimise compression”, “Delete metadata‘ and “Clear transparent (premultiplied) pixels” selected. To the best of my knowledge, Papa’s Best Optimizer performs only lossless .png optimisations, and using ImageMagick’s compare functionality seemed to confirm this in the samples I tested.
|
(I think the build failing isn’t my fault, it looks like CurseMaven is down.) |
|
You should rebase on the branch again as the cursemaven thing have been fixed |
These file size reductions came from using the program "ImageOptim" (https://github.com/ImageOptim/ImageOptim), with only lossless optimisations enabled, and all .png tools enabled. These files were additionally optimised further by then running the results through “Papa’s Best Optimizer” again (used in the previous commit), and continuing to cycle between the two programs until no further improvements were made.
The command "git merge --strategy-option theirs upstream/1.12-dev" was used to apply any changes to .png files from the upstream repository to this branch when merging.
The same process used to optimise the previous files was used again for the new and updated files. I’m fairly certain that some of the optimised files have issues which need to be manually corrected, so I’ll probably do that in the next commit.
FileOptimizer can be found at this (https://nikkhokkho.sourceforge.io/static.php?page=FileOptimizer) address. FileOptimizer claims to only perform lossless optimizations, but I’ll work on verifying that no quality reduction has occurred in any files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Optimised, not yet properly tested and verified:
This was achieved through using “Papa’s Best Optimizer” (which can be downloaded from https://papas-best.com/optimizer_en) with “Optimise compression”, “Delete metadata" and “Clear transparent (premultiplied) pixels” selected, as well as "ImageOptim" (which can be downloaded from https://github.com/ImageOptim/ImageOptim), with only lossless optimisations enabled, and all .png tools enabled. I’m fairly certain that some of the optimised files have issues which need to be manually corrected, so I’ll probably do that in the next commit.
Note: As I've modified a large amount of files, I have not been able to verify that they are all exactly the same as before, which is why this is a draft PR. Once I’m satisfied with the level of optimisation across all assets, I will work through providing an easy way to verify that all content is the same.