This repository has been archived by the owner on Oct 16, 2021. It is now read-only.
changes to include SaSS Source maps in DEV build #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have got this working really well in Chrome/Edge. The settings
--source-map-urls=absolute > Points to the actual file, and Chrome will take you to the file from the inspector. The Firefox
--embed-source-map > this just makes it all part of the index.HTML file
minifyCSS: false is required to make this work, otherwise all the comments are deleted.
This setting has minimal impact on product build. (239 bytes vs 238 with it set to true). This is because sass is doing the compression with --style=compressed,
The difference is due to minifyCSS removing /*# sourceMappingURL=global.css.map */, while --style=compressed does not.
The experience in Chrome is really good from my perspective. Thoughts?