fix(AttachmentExtractor): set probe timeout

Androz2091 · Oct 14, 2023 · 671afaa · 671afaa
1 parent b30960f
commit 671afaa
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 6 deletions.
diff --git a/packages/discord-player/src/Player.ts b/packages/discord-player/src/Player.ts
@@ -86,6 +86,7 @@ export class Player extends PlayerEventsEmitter<PlayerEvents> {
             queryCache: options.queryCache === null ? null : options.queryCache || new QueryCache(this),
             useLegacyFFmpeg: false,
             skipFFmpeg: false,
+            probeTimeout: 5000,
             ...options,
             ytdlOptions: {
                 highWaterMark: 1 << 25,

diff --git a/packages/discord-player/src/types/types.ts b/packages/discord-player/src/types/types.ts
@@ -519,4 +519,8 @@ export interface PlayerInitOptions {
      * Skip ffmpeg process when possible
      */
     skipFFmpeg?: boolean;
+    /**
+     * The probe timeout in milliseconds. Defaults to 5000.
+     */
+    probeTimeout?: number;
 }
diff --git a/packages/extractor/src/extractors/AttachmentExtractor.ts b/packages/extractor/src/extractors/AttachmentExtractor.ts
@@ -58,7 +58,14 @@ export class AttachmentExtractor extends BaseExtractor {
                 try {
                     // eslint-disable-next-line
                     const mediaplex = require('mediaplex') as typeof import('mediaplex');
-                    const { result, stream } = await mediaplex.probeStream(data);
+                    const timeout = this.context.player.options.probeTimeout ?? 5000;
+
+                    const { result, stream } = (await Promise.race([
+                        mediaplex.probeStream(data),
+                        new Promise((_, r) => {
+                            setTimeout(() => r(new Error('Timeout')), timeout);
+                        })
+                    ])) as Awaited<ReturnType<typeof mediaplex.probeStream>>;
 
                     if (result) {
                         trackInfo.duration = result.duration * 1000;
@@ -121,12 +128,19 @@ export class AttachmentExtractor extends BaseExtractor {
                     // eslint-disable-next-line
                     const mediaplex = require('mediaplex') as typeof import('mediaplex');
 
-                    const { result, stream } = await mediaplex.probeStream(
-                        createReadStream(query, {
-                            start: 0,
-                            end: 1024 * 1024 * 10
+                    const timeout = this.context.player.options.probeTimeout ?? 5000;
+
+                    const { result, stream } = (await Promise.race([
+                        mediaplex.probeStream(
+                            createReadStream(query, {
+                                start: 0,
+                                end: 1024 * 1024 * 10
+                            })
+                        ),
+                        new Promise((_, r) => {
+                            setTimeout(() => r(new Error('Timeout')), timeout);
                         })
-                    );
+                    ])) as Awaited<ReturnType<typeof mediaplex.probeStream>>;
 
                     if (result) {
                         trackInfo.duration = result.duration * 1000;