-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update external dependencies #143
Update external dependencies #143
Conversation
Updated external dependencies to latest versions, and built using Android Studio 2.3. Working without crashing when scan is started on device running AOSP 7.1.1 ROM. Made changes to resolve the following issue encountered:
Reflect the following changes in the material-dialogs dependency to remove the JitPack Maven repository and fall back to using jCenter instead (the default Maven repository used by Android Studio): Resolved the following issue I encountered when using Android Support Repository version 47.0.0: |
This may also fix the following issues: #138 Crash on CVE-2015-1474 |
@nailyk-fr Please will you review this? |
Try to build since I receive your mail but since I change the source from CopperHead to AndroidVTS it fail everytime. Last error before I gave up:
P.S.: Am building 'in-chain' and really don't know how gradlew works. |
@nailyk-fr I found and resolved the issue. The dependency name has changed and no longer has .github. in it. Not sure why it built for me, maybe I still had the JitPack Maven version cached or something. Updated pull request with the fix. |
Now it build:
thanks. I test the apk asap. |
Build perfect in the Copperhead N toolchain, run perfect on my both z3 (cm-12.1 & Lineage-14.1). P.S.: idk how to make a review on this repo :s |
@nailyk-fr To make a review, click on the 'Files changed' tab on the top of this page, then choose the green 'Review changes' button at the top right to get a drop-down box with options to Comment, Approve, or Request changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build perfect in CopperHead N chain, works fine on cm-12.1 and Lineage-14.1.
(old post: #143 (comment))
Sorry don't know it was avaiable on the file tab only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@Fuzion24 ok to merge this? |
👍 |
No description provided.