Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external dependencies #143

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Update external dependencies #143

merged 1 commit into from
Mar 30, 2017

Conversation

m00head
Copy link
Contributor

@m00head m00head commented Mar 28, 2017

No description provided.

@m00head
Copy link
Contributor Author

m00head commented Mar 28, 2017

Updated external dependencies to latest versions, and built using Android Studio 2.3. Working without crashing when scan is started on device running AOSP 7.1.1 ROM.

Made changes to resolve the following issue encountered:

Running dex as a separate process.

To run dex in process, the Gradle daemon needs a larger heap.
It currently has 1024 MB.
For faster builds, increase the maximum heap size for the Gradle daemon to at least 1536 MB.
To do this set org.gradle.jvmargs=-Xmx1536M in the project gradle.properties.
For more information see https://docs.gradle.org/current/userguide/build_environment.html

Reflect the following changes in the material-dialogs dependency to remove the JitPack Maven repository and fall back to using jCenter instead (the default Maven repository used by Android Studio):
afollestad/material-dialogs@3e69b76

Resolved the following issue I encountered when using Android Support Repository version 47.0.0:
http://stackoverflow.com/questions/42949974/android-support-repo-46-0-0-with-android-studio-2-3

@m00head
Copy link
Contributor Author

m00head commented Mar 28, 2017

This may also fix the following issues:

#138 Crash on CVE-2015-1474
#140 VTS crashes on CM 14.1 (Android 7.1(.1))?
#142 VTS crashes on Nexus 6P 7.1.1

@m00head
Copy link
Contributor Author

m00head commented Mar 28, 2017

@nailyk-fr Please will you review this?

@nailyk-fr
Copy link

nailyk-fr commented Mar 28, 2017

Try to build since I receive your mail but since I change the source from CopperHead to AndroidVTS it fail everytime. Last error before I gave up:

FAILURE: Build failed with an exception.

  • What went wrong:
    A problem occurred configuring project ':app'.
    Could not resolve all dependencies for configuration ':app:_debugApkCopy'.
    Could not find com.github.afollestad.material-dialogs:core:0.9.4.2.
    Required by:
    project :app

P.S.: Am building 'in-chain' and really don't know how gradlew works.

@m00head
Copy link
Contributor Author

m00head commented Mar 28, 2017

@nailyk-fr I found and resolved the issue. The dependency name has changed and no longer has .github. in it. Not sure why it built for me, maybe I still had the JitPack Maven version cached or something.

Updated pull request with the fix.

@nailyk-fr
Copy link

Now it build:

[100% 3/3] Install: out/target/product/hammerhead/system/app/AndroidVTS/AndroidVTS.apk

make completed successfully (02:43 (mm:ss))

thanks. I test the apk asap.

@nailyk-fr
Copy link

nailyk-fr commented Mar 28, 2017

Build perfect in the Copperhead N toolchain, run perfect on my both z3 (cm-12.1 & Lineage-14.1).
Nice work @m00head , thanks!

P.S.: idk how to make a review on this repo :s

@m00head
Copy link
Contributor Author

m00head commented Mar 28, 2017

@nailyk-fr To make a review, click on the 'Files changed' tab on the top of this page, then choose the green 'Review changes' button at the top right to get a drop-down box with options to Comment, Approve, or Request changes.

Copy link

@nailyk-fr nailyk-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build perfect in CopperHead N chain, works fine on cm-12.1 and Lineage-14.1.
(old post: #143 (comment))

@nailyk-fr
Copy link

Sorry don't know it was avaiable on the file tab only.
Not the right place to ask, but why not merge my Android.mk? (mostly extracted from CopperHead one)

Copy link

@martinl martinl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@m00head
Copy link
Contributor Author

m00head commented Mar 30, 2017

@Fuzion24 ok to merge this?

@Fuzion24
Copy link
Contributor

👍

@Fuzion24 Fuzion24 merged commit 9422cae into AndroidVTS:master Mar 30, 2017
@m00head m00head deleted the update_external_dependencies branch March 30, 2017 15:27
@m00head m00head mentioned this pull request Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants