Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpyara.sh: explicitly check the folders generated by fsck.erofs #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shra1V32
Copy link

There's one case with fsck.erofs where it generates folder but fails to extract. The script will now check whether the generated folders are empty or not.

There's one case with `fsck.erofs` where it generates folder but fails to extract. The script will now check whether the generated folders are empty or not.
@OneNormalUsername
Copy link
Collaborator

Thank you for this PR. For testing purposes, would you be able to share with which image and which firmware this happens?

@Shra1V32
Copy link
Author

Shra1V32 commented Jun 11, 2023

@OneNormalUsername
Copy link
Collaborator

xiaomi.eu is a custom ROM though, is there any stock ROM with split sparse super images?

@Shra1V32
Copy link
Author

I understand that xiaomi.eu is a custom ROM and yeah, I've never any OEM do that as per my knowledge. But any OEM may also generate using simg2simg. This PR is intended just for the test case nothing else, Just wanted to give a try. What I liked is that, xiaomi.eu is able to make hybrid packages where split sparse can be flashed through recovery & even fastboot with the same files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants