Skip to content

Commit

Permalink
ANDROID: GKI: Fix up "do not export symbol_get/put()" commit
Browse files Browse the repository at this point in the history
When removing the export from symbol_get/put(), I disabled lots of
different drivers in the allmodconfig build file.

As some pointed out, that's not the nicest thing to do, as we really do
want the build coverage, so instead, "tweak" the Kconfig files to make
the problamatic modules be built-in to the kernel image.  That removes
the problem of the export going away and still gives us good build
testing coverage, without modifying any real-world device
configurations.

Note, 3 config options are "turned off" so they can not be selected, as
they could not be worked around in any semi-sane manner:
	VIDEO_CX23885
	DELL_LAPTOP
	SAMPLE_HW_BREAKPOINT
none of which affects any known Android devices.

Bug: 162613590
Fixes: 882b7ca ("ANDROID: GKI: do not export symbol_get/put()")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Change-Id: Ia28f73a64566438940b876a5d9c1a0137c6304d0
  • Loading branch information
gregkh committed Aug 1, 2020
1 parent 53b501f commit a35cf72
Show file tree
Hide file tree
Showing 42 changed files with 90 additions and 119 deletions.
2 changes: 1 addition & 1 deletion arch/x86/kvm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ menuconfig VIRTUALIZATION
if VIRTUALIZATION

config KVM
tristate "Kernel-based Virtual Machine (KVM) support"
bool "Kernel-based Virtual Machine (KVM) support"
depends on HAVE_KVM
depends on HIGH_RES_TIMERS
# for TASKSTATS/TASK_DELAY_ACCT:
Expand Down
32 changes: 0 additions & 32 deletions build.config.allmodconfig
Original file line number Diff line number Diff line change
@@ -1,44 +1,12 @@
DEFCONFIG=allmodconfig

# When trying to prevent others from using symbol_get/put we need to exclude a
# number of in-kernel modules that use those functions.
SYMBOL_GET_USERS=" \
-d CAIF \
-d DELL_LAPTOP \
-d DRM_I915 \
-d DVB_USB \
-d DVB_USB_V2 \
-d FSL_ENETC \
-d FSL_ENETC_VF \
-d INTEL_IPS \
-d KVM \
-d MEDIA_DIGITAL_TV_SUPPORT \
-d MEDIA_PCI_SUPPORT \
-d MEDIA_RADIO_SUPPORT \
-d MTD_CFI \
-d MTD_GEN_PROBE \
-d MTD_HYPERBUS \
-d MTD_JEDECPROBE \
-d MTD_TS5500 \
-d NFS_V4 \
-d SAMPLE_HW_BREAKPOINT \
-d VFIO \
-d VIDEO_CX231XX \
-d VIDEO_EM28XX \
-d VIDEO_GO7007 \
-d VIDEO_PVRUSB2 \
-d VIDEO_TM6000 \
-d VIDEO_USBVISION \
"

POST_DEFCONFIG_CMDS="update_config"
function update_config() {
${KERNEL_DIR}/scripts/config --file ${OUT_DIR}/.config \
-d TEST_KMOD \
-d CPU_BIG_ENDIAN \
-d STM \
-d TEST_MEMCAT_P \
${SYMBOL_GET_USERS} \
-e UNWINDER_FRAME_POINTER \

(cd ${OUT_DIR} && \
Expand Down
2 changes: 1 addition & 1 deletion drivers/char/agp/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
menuconfig AGP
tristate "/dev/agpgart (AGP Support)"
bool "/dev/agpgart (AGP Support)"
depends on ALPHA || IA64 || PARISC || PPC || X86
depends on PCI
---help---
Expand Down
4 changes: 2 additions & 2 deletions drivers/gpu/drm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
#
menuconfig DRM
tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
bool "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && HAS_DMA
select DRM_PANEL_ORIENTATION_QUIRKS
select HDMI
Expand Down Expand Up @@ -55,7 +55,7 @@ config DRM_DEBUG_MM
If in doubt, say "N".

config DRM_DEBUG_SELFTEST
tristate "kselftests for DRM"
bool "kselftests for DRM"
depends on DRM
depends on DEBUG_KERNEL
select PRIME_NUMBERS
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_I915
tristate "Intel 8xx/9xx/G3x/G4x/HD Graphics"
bool "Intel 8xx/9xx/G3x/G4x/HD Graphics"
depends on DRM
depends on X86 && PCI
select INTEL_GTT
Expand Down
2 changes: 1 addition & 1 deletion drivers/i2c/algos/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ menu "I2C Algorithms"
visible if !I2C_HELPER_AUTO

config I2C_ALGOBIT
tristate "I2C bit-banging interfaces"
bool "I2C bit-banging interfaces"

config I2C_ALGOPCF
tristate "I2C PCF 8584 interfaces"
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/common/b2c2/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_B2C2_FLEXCOP
tristate
bool
depends on DVB_CORE && I2C
depends on DVB_B2C2_FLEXCOP_PCI || DVB_B2C2_FLEXCOP_USB
default y
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/pci/bt8xx/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_BT848
tristate "BT848 Video For Linux"
bool "BT848 Video For Linux"
depends on VIDEO_DEV && PCI && I2C && VIDEO_V4L2
select I2C_ALGOBIT
select VIDEOBUF_DMA_SG
Expand All @@ -23,7 +23,7 @@ config VIDEO_BT848
module will be called bttv.

config DVB_BT8XX
tristate "DVB/ATSC Support for bt878 based TV cards"
bool "DVB/ATSC Support for bt878 based TV cards"
depends on DVB_CORE && PCI && I2C && VIDEO_BT848
select DVB_MT352 if MEDIA_SUBDRV_AUTOSELECT
select DVB_SP887X if MEDIA_SUBDRV_AUTOSELECT
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/cx18/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_CX18
tristate "Conexant cx23418 MPEG encoder support"
bool "Conexant cx23418 MPEG encoder support"
depends on VIDEO_V4L2 && DVB_CORE && PCI && I2C
select I2C_ALGOBIT
select VIDEOBUF_VMALLOC
Expand Down
1 change: 1 addition & 0 deletions drivers/media/pci/cx23885/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
config VIDEO_CX23885
tristate "Conexant cx23885 (2388x successor) support"
depends on DVB_CORE && VIDEO_DEV && PCI && I2C && INPUT && SND
depends on BROKEN
select SND_PCM
select I2C_ALGOBIT
select VIDEO_TUNER
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/pci/cx88/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ config VIDEO_CX88_ALSA
module will be called cx88-alsa.

config VIDEO_CX88_BLACKBIRD
tristate "Blackbird MPEG encoder support (cx2388x + cx23416)"
bool "Blackbird MPEG encoder support (cx2388x + cx23416)"
depends on VIDEO_CX88
select VIDEO_CX2341X
help
Expand All @@ -43,7 +43,7 @@ config VIDEO_CX88_BLACKBIRD
module will be called cx88-blackbird.

config VIDEO_CX88_DVB
tristate "DVB/ATSC Support for cx2388x based TV cards"
bool "DVB/ATSC Support for cx2388x based TV cards"
depends on VIDEO_CX88 && DVB_CORE
select VIDEOBUF2_DVB
select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/ddbridge/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_DDBRIDGE
tristate "Digital Devices bridge support"
bool "Digital Devices bridge support"
depends on DVB_CORE && PCI && I2C
select DVB_LNBP21 if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV6110x if MEDIA_SUBDRV_AUTOSELECT
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/dm1105/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_DM1105
tristate "SDMC DM1105 based PCI cards"
bool "SDMC DM1105 based PCI cards"
depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT
select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
Expand Down
6 changes: 3 additions & 3 deletions drivers/media/pci/mantis/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config MANTIS_CORE
tristate "Mantis/Hopper PCI bridge based devices"
bool "Mantis/Hopper PCI bridge based devices"
depends on PCI && I2C && INPUT && RC_CORE

help
Expand All @@ -9,7 +9,7 @@ config MANTIS_CORE
Say Y if you own such a device and want to use it.

config DVB_MANTIS
tristate "MANTIS based cards"
bool "MANTIS based cards"
depends on MANTIS_CORE && DVB_CORE && PCI && I2C
select DVB_MB86A16 if MEDIA_SUBDRV_AUTOSELECT
select DVB_ZL10353 if MEDIA_SUBDRV_AUTOSELECT
Expand All @@ -28,7 +28,7 @@ config DVB_MANTIS
If unsure say N.

config DVB_HOPPER
tristate "HOPPER based cards"
bool "HOPPER based cards"
depends on MANTIS_CORE && DVB_CORE && PCI && I2C
select DVB_ZL10353 if MEDIA_SUBDRV_AUTOSELECT
select DVB_PLL
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/netup_unidvb/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_NETUP_UNIDVB
tristate "NetUP Universal DVB card support"
bool "NetUP Universal DVB card support"
depends on DVB_CORE && VIDEO_DEV && PCI && I2C && SPI_MASTER
select VIDEOBUF2_DVB
select VIDEOBUF2_VMALLOC
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/ngene/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_NGENE
tristate "Micronas nGene support"
bool "Micronas nGene support"
depends on DVB_CORE && PCI && I2C
select DVB_LNBP21 if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV6110x if MEDIA_SUBDRV_AUTOSELECT
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/pci/saa7134/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ config VIDEO_SAA7134_RC
bool "Philips SAA7134 Remote Controller support"
depends on RC_CORE
depends on VIDEO_SAA7134
depends on !(RC_CORE=m && VIDEO_SAA7134=y)
#depends on !(RC_CORE=m && VIDEO_SAA7134=y)
default y
help
Enables Remote Controller support on saa7134 driver.

config VIDEO_SAA7134_DVB
tristate "DVB/ATSC Support for saa7134 based TV cards"
bool "DVB/ATSC Support for saa7134 based TV cards"
depends on VIDEO_SAA7134 && DVB_CORE
select VIDEOBUF2_DVB
select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/saa7164/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_SAA7164
tristate "NXP SAA7164 support"
bool "NXP SAA7164 support"
depends on DVB_CORE && VIDEO_DEV && PCI && I2C
select I2C_ALGOBIT
select FW_LOADER
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/pci/smipcie/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_SMIPCIE
tristate "SMI PCIe DVBSky cards"
bool "SMI PCIe DVBSky cards"
depends on DVB_CORE && PCI && I2C
select I2C_ALGOBIT
select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
Expand Down
14 changes: 7 additions & 7 deletions drivers/media/pci/ttpci/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ config DVB_AV7110_IR
default DVB_AV7110

config DVB_AV7110
tristate "AV7110 cards"
bool "AV7110 cards"
depends on DVB_CORE && PCI && I2C
select TTPCI_EEPROM
select VIDEO_SAA7146_VV
Expand Down Expand Up @@ -40,7 +40,7 @@ config DVB_AV7110
config DVB_AV7110_OSD
bool "AV7110 OSD support"
depends on DVB_AV7110
default y if DVB_AV7110=y || DVB_AV7110=m
default y if DVB_AV7110=y
help
The AV7110 firmware provides some code to generate an OnScreenDisplay
on the video output. This is kind of nonstandard and not guaranteed to
Expand All @@ -52,7 +52,7 @@ config DVB_AV7110_OSD
All other people say N.

config DVB_BUDGET_CORE
tristate "SAA7146 DVB cards (aka Budget, Nova-PCI)"
bool "SAA7146 DVB cards (aka Budget, Nova-PCI)"
depends on DVB_CORE && PCI && I2C
select VIDEO_SAA7146
select TTPCI_EEPROM
Expand All @@ -62,7 +62,7 @@ config DVB_BUDGET_CORE
MPEG2 decoder.

config DVB_BUDGET
tristate "Budget cards"
bool "Budget cards"
depends on DVB_BUDGET_CORE && I2C
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
select DVB_VES1X93 if MEDIA_SUBDRV_AUTOSELECT
Expand All @@ -88,7 +88,7 @@ config DVB_BUDGET
module will be called budget.

config DVB_BUDGET_CI
tristate "Budget cards with onboard CI connector"
bool "Budget cards with onboard CI connector"
depends on DVB_BUDGET_CORE && I2C
select DVB_STV0297 if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
Expand All @@ -115,7 +115,7 @@ config DVB_BUDGET_CI
module will be called budget-ci.

config DVB_BUDGET_AV
tristate "Budget cards with analog video inputs"
bool "Budget cards with analog video inputs"
depends on DVB_BUDGET_CORE && I2C
select VIDEO_SAA7146_VV
depends on VIDEO_DEV # dependencies of VIDEO_SAA7146_VV
Expand All @@ -138,7 +138,7 @@ config DVB_BUDGET_AV
module will be called budget-av.

config DVB_BUDGET_PATCH
tristate "AV7110 cards with Budget Patch"
bool "AV7110 cards with Budget Patch"
depends on DVB_BUDGET_CORE && I2C
depends on DVB_AV7110
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/platform/sti/c8sectpfe/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_C8SECTPFE
tristate "STMicroelectronics C8SECTPFE DVB support"
bool "STMicroelectronics C8SECTPFE DVB support"
depends on PINCTRL && DVB_CORE && I2C
depends on ARCH_STI || ARCH_MULTIPLATFORM || COMPILE_TEST
select FW_LOADER
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/rc/Kconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only

menuconfig RC_CORE
tristate "Remote Controller support"
bool "Remote Controller support"
depends on INPUT
help
Enable support for Remote Controllers on Linux. This is
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/spi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if SPI
menu "Media SPI Adapters"

config CXD2880_SPI_DRV
tristate "Sony CXD2880 SPI support"
bool "Sony CXD2880 SPI support"
depends on DVB_CORE && SPI
default m if !MEDIA_SUBDRV_AUTOSELECT
help
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/usb/as102/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_AS102
tristate "Abilis AS102 DVB receiver"
bool "Abilis AS102 DVB receiver"
depends on DVB_CORE && USB && I2C && INPUT
select FW_LOADER
help
Expand Down
4 changes: 2 additions & 2 deletions drivers/media/usb/au0828/Kconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only

config VIDEO_AU0828
tristate "Auvitek AU0828 support"
bool "Auvitek AU0828 support"
depends on I2C && INPUT && DVB_CORE && USB && VIDEO_V4L2
select MEDIA_CONTROLLER
select MEDIA_CONTROLLER_DVB
Expand Down Expand Up @@ -35,7 +35,7 @@ config VIDEO_AU0828_V4L2
config VIDEO_AU0828_RC
bool "AU0828 Remote Controller support"
depends on RC_CORE
depends on !(RC_CORE=m && VIDEO_AU0828=y)
#depends on !(RC_CORE=m && VIDEO_AU0828=y)
depends on VIDEO_AU0828
help
Enables Remote Controller support on au0828 driver.
4 changes: 2 additions & 2 deletions drivers/media/usb/cx231xx/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_CX231XX
tristate "Conexant cx231xx USB video capture support"
bool "Conexant cx231xx USB video capture support"
depends on VIDEO_DEV && I2C && I2C_MUX
select VIDEO_TUNER
select VIDEO_TVEEPROM
Expand Down Expand Up @@ -39,7 +39,7 @@ config VIDEO_CX231XX_ALSA
module will be called cx231xx-alsa

config VIDEO_CX231XX_DVB
tristate "DVB/ATSC Support for Cx231xx based TV cards"
bool "DVB/ATSC Support for Cx231xx based TV cards"
depends on VIDEO_CX231XX && DVB_CORE
select MEDIA_TUNER_XC5000 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_TDA18271 if MEDIA_SUBDRV_AUTOSELECT
Expand Down
Loading

0 comments on commit a35cf72

Please sign in to comment.