feat(app): add dynamic-plugins-info to the OTHER dockerfile too so Ca…

…chito can find this @internal package; docs(contributing): add note about BOTH dockerfiles needing to be updated (redhat-developer#1192) * feat(app): add dynamic-plugins-info to the OTHER dockerfile too so Cachito can find this @internal package Signed-off-by: Nick Boldt <[email protected]> * add note about BOTH dockerfiles needing to be updated Signed-off-by: Nick Boldt <[email protected]> * prettier *shakes fist* Signed-off-by: Nick Boldt <[email protected]> --------- Signed-off-by: Nick Boldt <[email protected]>
AndrienkoAleksandr · Apr 18, 2024 · 6c0bf5e · 6c0bf5e
1 parent ae2dd93
commit 6c0bf5e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.rhdh/docker/Dockerfile b/.rhdh/docker/Dockerfile
@@ -51,6 +51,7 @@ COPY $EXTERNAL_SOURCE_NESTED/package.json $EXTERNAL_SOURCE_NESTED/yarn.lock ./
 COPY $EXTERNAL_SOURCE_NESTED/packages/app/package.json ./packages/app/package.json
 COPY $EXTERNAL_SOURCE_NESTED/packages/backend/package.json ./packages/backend/package.json
 COPY $EXTERNAL_SOURCE_NESTED/plugins/scalprum-backend/package.json ./plugins/scalprum-backend/package.json
+COPY $EXTERNAL_SOURCE_NESTED/plugins/dynamic-plugins-info/package.json ./plugins/dynamic-plugins-info/package.json
 COPY $EXTERNAL_SOURCE_NESTED/plugins/dynamic-plugins-info-backend/package.json ./plugins/dynamic-plugins-info-backend/package.json
 COPY $EXTERNAL_SOURCE_NESTED/plugins/auth-backend-module-oidc-provider/package.json ./plugins/auth-backend-module-oidc-provider/package.json
 

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -66,6 +66,19 @@ Before submitting the PR, it is important to run some of our package scripts to
 
 A special note. If there will be changes to the [app config](https://github.com/janus-idp/backstage-showcase/blob/main/app-config.yaml), we ask that [documentation](https://github.com/janus-idp/backstage-showcase/blob/main/showcase-docs/getting-started.md) be updated if it will be a requirement for running the app. We also ask to ensure that the app will still work in the case of dummy information being supplied to the app config. While it is not a hard requirement, it does help others with quickly being able to get up and running with the showcase app.
 
+### Adding statically linked plugins for frontend and backend
+
+When contributing a new @internal plugin into this repo, you must remember to add the plugin to the Dockerfiles under the section titled `Stage 2 - Install dependencies`:
+
+- [Upstream Dockerfile](.rhdh/docker/Dockerfile)
+- [Downstream Dockerfile](docker/Dockerfile)
+
+For example:
+
+```
+COPY $EXTERNAL_SOURCE_NESTED/plugins/dynamic-plugins-info/package.json ./plugins/dynamic-plugins-info/package.json
+```
+
 ## Support
 
 You can reach out to us in our [community slack channel](https://join.slack.com/t/janus-idp/shared_invite/zt-1pxtehxom-fCFtF9rRe3vFqUiFFeAkmg) if you run into any issues with setup, running, or testing the application. Members of the team and community can assist you with questions and concerns you might have. Even if you don't need help, please consider joining and being involved in our community.