Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TEST_SPEED.cfg #80

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update TEST_SPEED.cfg #80

wants to merge 5 commits into from

Conversation

Vykori
Copy link

@Vykori Vykori commented Jun 11, 2023

  • Added extra safety measures
  • Fixed typos and indentation inconsistencies
  • Added extra movements to test moving one way, and then immediately back again
  • Tested on Voron 0.2

- Added extra safety measures
- Fixed typos
@AndrewEllis93
Copy link
Owner

Thanks for the contribution. Some of the changes were intentional behaviors:

  • The first G28 being unconditional is just a foolproofing measure. Your printer might still be "homed" but shifted from a previous test. We want to make sure to home again to ensure we're starting with a clean slate.

  • The last G28 is a full XYZ home rather than G28 X Y intentionally, to fix an issue with Switchwire.

  • The removed G90 after that is not necessary in most cases, but I put it there to account for people's poorly written homing_overrides, as a "just in case" sort of thing.

The safe speed and the additional stallguard delay look good. I might go even lower (max_velocity / 3 or 4 maybe?) but that's debatable

@Vykori
Copy link
Author

Vykori commented Jun 12, 2023

Ooh good insight. I'll put those g-codes back in and re-submit

@Vykori Vykori marked this pull request as draft June 12, 2023 20:27
- Fix regressions pointed out by Ellis AndrewEllis93#80 (comment)
- Added additional movements to test toolhead moving one way then back again in all combinations
@Vykori
Copy link
Author

Vykori commented Jun 13, 2023

I've added extra moves to the box and diagonal patterns to additionally test moving one way, then immediately moving back again. My thinking is the square_corner_velocity might get doubled-up in this type of movement.

Demo: https://youtu.be/kqPkX30OyF0

Fixed an accidentally misplaced G0 movement in both the large and small box pattern
@Vykori
Copy link
Author

Vykori commented Jun 13, 2023

Should this be two separate PRs? I'm new to Git things...

@Vykori Vykori marked this pull request as ready for review June 13, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants