Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.5 update to 0.9.beta #46

Open
wants to merge 83 commits into
base: 1.16.5
Choose a base branch
from
Open

Conversation

wntiv-main
Copy link

u might need to look through the changes I'm quite new to GitHub and modding

@wntiv-main wntiv-main marked this pull request as draft August 10, 2022 05:33
@wntiv-main wntiv-main marked this pull request as ready for review August 10, 2022 07:03
@wntiv-main wntiv-main marked this pull request as draft August 10, 2022 07:05
@wntiv-main wntiv-main marked this pull request as ready for review August 10, 2022 07:18
@wntiv-main wntiv-main marked this pull request as draft August 10, 2022 07:28
@Andrew6rant
Copy link
Owner

Holy Hell! Thanks for the PR (and apologies for subjecting you to this codebase).

I just tested it out for a bit and everything seems to be working well, if you want me to push the jar to CurseForge, just let me know.

You should also drop your name in the 1.16.5 fabric.mod.json, you deserve it for backporting all this stuff

@wntiv-main wntiv-main marked this pull request as ready for review August 11, 2022 00:43
@wntiv-main
Copy link
Author

wntiv-main commented Aug 11, 2022

also the "check for empty item frame" commit (9e4f372) should be added to 1.18 and 1.19 as well

Edit: including the fix for it in commit a004ba2

@wntiv-main
Copy link
Author

You can add the jar to CurseForge if you want, it may be useful for people like me who want an updated 1.16.5 version. Be prepared for complaints about stuff not working tho, I have no clue how messy my code is.

@wntiv-main wntiv-main marked this pull request as draft August 11, 2022 04:30
@wntiv-main wntiv-main marked this pull request as ready for review August 11, 2022 04:35
@wntiv-main
Copy link
Author

unfortunatly in 1.16.5 the pick-block result for entities is hardcoded in the net.minecraft.client.MinecraftClient class in the middle of the doItemPick() method which makes mod compatibility more complicated than I am willing to fix. For now I have just copied their code into the EntityUtil class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants