-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Testing pycaw.magic #45
Draft
TurboAnonym
wants to merge
1
commit into
AndreMiras:develop
Choose a base branch
from
TurboAnonym:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
We're only constructing the object for now
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
We're only constructing the object for now
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2022
FYI I've added a few dumb (and maybe flaky) tests in tests/test_magic.py for a start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreMiras not yet ready 😁
just starting the discussion ...
I have thought about how to add unit testing:
that was working for me, but of course its nowhere an automatic solution. (Also it doesnt test MagicApp)
taskkill /F /IM vlc.exe
to just kill all open vlc windows. VLC has the characteristic, that every new app window will create a new WAS (session). That way we could easily stress test pycaw (Opening a lot of windows and closing them all instantly).Im proposing to use vlc since i cant find any other nice crossplattform solution (win 7 - 10)
What wont work:
Internet Explorer:
start iexplore music.mp3
or any other file format will download the file<audio autoplay="autoplay"><source src="music.mp3" /></audio>
a simple website wont work either: ProblemWindows Media Player:
What could work:
taskkill /F /IM powershell.exe
what could also interfere with the unit testing)