Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added coupon activation API #8

Merged
merged 8 commits into from
Sep 30, 2023
Merged

Added coupon activation API #8

merged 8 commits into from
Sep 30, 2023

Conversation

Woyken
Copy link
Contributor

@Woyken Woyken commented Sep 26, 2023 •
edited
Loading

  • Added API to fetch coupons
  • Added API to activate/deactivate coupons
  • Added command line tool to activate all available coupons

Good start for #7, just add scheduled job once a day and you're done

Andre0512
Andre0512 requested changes Sep 29, 2023
View reviewed changes
Copy link
Owner

@Andre0512 Andre0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your nice work and good documentation! 🙂
Please have a look at my comments and please format the code with black (pip install black && black lidlplus/), than we can merge it.

lidlplus/__main__.py Outdated Show resolved Hide resolved
lidlplus/__main__.py Outdated Show resolved Hide resolved
lidlplus/__main__.py Outdated Show resolved Hide resolved
lidlplus/api.py Outdated Show resolved Hide resolved
@Andre0512 Andre0512 merged commit b8606e5 into Andre0512:main Sep 30, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre0512 Andre0512 Andre0512 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Woyken @Andre0512