Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transform): prevent running actions against different instances of handlers #96

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Anber
Copy link
Owner

@Anber Anber commented Aug 6, 2024

Motivation

wtlin1228 found an issue with handlers and actions: if multiple handlers are passed to an action, side effects from all handlers except the first one will be ignored. It's not a problem because, by design, an action should be run with the same instance of a handler. However, the fast check showed that it's not true for resolveImports actions that are constantly recreated because of resolve functions passed from bundlers. In some cases, it may break HMR in Webpack and lead to inconsistent logs in Vite/Rollup.

Summary

  • action.run now checks that it is run with the same handler instance.
  • A few layers of memoisation have been added, so resolveImports won't be recreated if it's unnecessary.

Copy link

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: b2895cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant