fix(transform): prevent running actions against different instances of handlers #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
wtlin1228 found an issue with handlers and actions: if multiple handlers are passed to an action, side effects from all handlers except the first one will be ignored. It's not a problem because, by design, an action should be run with the same instance of a handler. However, the fast check showed that it's not true for
resolveImports
actions that are constantly recreated because ofresolve
functions passed from bundlers. In some cases, it may break HMR in Webpack and lead to inconsistent logs in Vite/Rollup.Summary
action.run
now checks that it is run with the same handler instance.resolveImports
won't be recreated if it's unnecessary.