Update dreamhost _authenticate to use dns-list_records instead of dom…

…ain-list_domains (#998)
AnalogJ · Nov 3, 2021 · 1088fe3 · 1088fe3
1 parent 64c5021
commit 1088fe3
Show file tree

Hide file tree

Showing 27 changed files with 55 additions and 54 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -29,7 +29,7 @@ lexicon/providers/dnsimple.py       @analogj
 lexicon/providers/dnsmadeeasy.py    @analogj @nydr
 lexicon/providers/dnspark.py        @analogj
 lexicon/providers/dnspod.py         @analogj
-lexicon/providers/dreamhost.py      @chhsiao1981
+lexicon/providers/dreamhost.py      @chhsiao1981 @ryan953
 lexicon/providers/dynu.py           @HerrFolgreich
 lexicon/providers/easydns.py        @analogj
 lexicon/providers/easyname.py       @astzweig @rqelibari

diff --git a/lexicon/providers/dreamhost.py b/lexicon/providers/dreamhost.py
@@ -100,14 +100,15 @@ def _record_to_dreamhost_record(record):
 
     def _authenticate(self):
         self.domain_id = None
-        payload = self._get("domain-list_domains")
+        payload = self._get("dns-list_records")
         data = payload.get("data", None)
         if data is None:
             raise AuthenticationError("Domain not found")
 
-        for domain in data:
-            if domain.get("domain", "") == self.domain:
+        for record in data:
+            if record.get("record", "") == self.domain and record.get("type", "") in ["A", "AAAA"]:
                 self.domain_id = self.domain
+                break
         if self.domain_id is None:
             raise AuthenticationError("Domain not found")
 

diff --git a/tests/fixtures/cassettes/dreamhost/IntegrationTests/test_provider_authenticate.yaml b/tests/fixtures/cassettes/dreamhost/IntegrationTests/test_provider_authenticate.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...amhost/IntegrationTests/test_provider_authenticate_with_unmanaged_domain_should_fail.yaml b/...amhost/IntegrationTests/test_provider_authenticate_with_unmanaged_domain_should_fail.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...tionTests/test_provider_when_calling_create_record_for_A_with_valid_name_and_content.yaml b/...tionTests/test_provider_when_calling_create_record_for_A_with_valid_name_and_content.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com","AXFR_IPS":"none","TTL_SEC":0,"DOMAINID":1047330,"SOA_EMAIL":"trinopoty@hotmail.com","EXPIRE_SEC":0,"RETRY_SEC":0,"STATUS":1,"DESCRIPTION":"","LPM_DISPLAYGROUP":"","REFRESH_SEC":0,"MASTER_IPS":"","TYPE":"master"}],"ERRORARRAY":[]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...Tests/test_provider_when_calling_create_record_for_CNAME_with_valid_name_and_content.yaml b/...Tests/test_provider_when_calling_create_record_for_CNAME_with_valid_name_and_content.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com","AXFR_IPS":"none","TTL_SEC":0,"DOMAINID":1047330,"SOA_EMAIL":"trinopoty@hotmail.com","EXPIRE_SEC":0,"RETRY_SEC":0,"STATUS":1,"DESCRIPTION":"","LPM_DISPLAYGROUP":"","REFRESH_SEC":0,"MASTER_IPS":"","TYPE":"master"}],"ERRORARRAY":[]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...ionTests/test_provider_when_calling_create_record_for_TXT_with_fqdn_name_and_content.yaml b/...ionTests/test_provider_when_calling_create_record_for_TXT_with_fqdn_name_and_content.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com","AXFR_IPS":"none","TTL_SEC":0,"DOMAINID":1047330,"SOA_EMAIL":"trinopoty@hotmail.com","EXPIRE_SEC":0,"RETRY_SEC":0,"STATUS":1,"DESCRIPTION":"","LPM_DISPLAYGROUP":"","REFRESH_SEC":0,"MASTER_IPS":"","TYPE":"master"}],"ERRORARRAY":[]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...ionTests/test_provider_when_calling_create_record_for_TXT_with_full_name_and_content.yaml b/...ionTests/test_provider_when_calling_create_record_for_TXT_with_full_name_and_content.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com","AXFR_IPS":"none","TTL_SEC":0,"DOMAINID":1047330,"SOA_EMAIL":"trinopoty@hotmail.com","EXPIRE_SEC":0,"RETRY_SEC":0,"STATUS":1,"DESCRIPTION":"","LPM_DISPLAYGROUP":"","REFRESH_SEC":0,"MASTER_IPS":"","TYPE":"master"}],"ERRORARRAY":[]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...onTests/test_provider_when_calling_create_record_for_TXT_with_valid_name_and_content.yaml b/...onTests/test_provider_when_calling_create_record_for_TXT_with_valid_name_and_content.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com","AXFR_IPS":"none","TTL_SEC":0,"DOMAINID":1047330,"SOA_EMAIL":"trinopoty@hotmail.com","EXPIRE_SEC":0,"RETRY_SEC":0,"STATUS":1,"DESCRIPTION":"","LPM_DISPLAYGROUP":"","REFRESH_SEC":0,"MASTER_IPS":"","TYPE":"master"}],"ERRORARRAY":[]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...sts/test_provider_when_calling_create_record_multiple_times_should_create_record_set.yaml b/...sts/test_provider_when_calling_create_record_multiple_times_should_create_record_set.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...Tests/test_provider_when_calling_create_record_with_duplicate_records_should_be_noop.yaml b/...Tests/test_provider_when_calling_create_record_with_duplicate_records_should_be_noop.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...grationTests/test_provider_when_calling_delete_record_by_filter_should_remove_record.yaml b/...grationTests/test_provider_when_calling_delete_record_by_filter_should_remove_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...st_provider_when_calling_delete_record_by_filter_with_fqdn_name_should_remove_record.yaml b/...st_provider_when_calling_delete_record_by_filter_with_fqdn_name_should_remove_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...st_provider_when_calling_delete_record_by_filter_with_full_name_should_remove_record.yaml b/...st_provider_when_calling_delete_record_by_filter_with_full_name_should_remove_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...ionTests/test_provider_when_calling_delete_record_by_identifier_should_remove_record.yaml b/...ionTests/test_provider_when_calling_delete_record_by_identifier_should_remove_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/..._when_calling_delete_record_with_record_set_by_content_should_leave_others_untouched.yaml b/..._when_calling_delete_record_with_record_set_by_content_should_leave_others_untouched.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...rationTests/test_provider_when_calling_delete_record_with_record_set_name_remove_all.yaml b/...rationTests/test_provider_when_calling_delete_record_with_record_set_name_remove_all.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...t/IntegrationTests/test_provider_when_calling_list_records_should_handle_record_sets.yaml b/...t/IntegrationTests/test_provider_when_calling_list_records_should_handle_record_sets.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...s/test_provider_when_calling_list_records_with_fqdn_name_filter_should_return_record.yaml b/...s/test_provider_when_calling_list_records_with_fqdn_name_filter_should_return_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...s/test_provider_when_calling_list_records_with_full_name_filter_should_return_record.yaml b/...s/test_provider_when_calling_list_records_with_full_name_filter_should_return_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...sts/test_provider_when_calling_list_records_with_invalid_filter_should_be_empty_list.yaml b/...sts/test_provider_when_calling_list_records_with_invalid_filter_should_be_empty_list.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...nTests/test_provider_when_calling_list_records_with_name_filter_should_return_record.yaml b/...nTests/test_provider_when_calling_list_records_with_name_filter_should_return_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...ationTests/test_provider_when_calling_list_records_with_no_arguments_should_list_all.yaml b/...ationTests/test_provider_when_calling_list_records_with_no_arguments_should_list_all.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...mhost/IntegrationTests/test_provider_when_calling_update_record_should_modify_record.yaml b/...mhost/IntegrationTests/test_provider_when_calling_update_record_should_modify_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...onTests/test_provider_when_calling_update_record_should_modify_record_name_specified.yaml b/...onTests/test_provider_when_calling_update_record_should_modify_record_name_specified.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...onTests/test_provider_when_calling_update_record_with_fqdn_name_should_modify_record.yaml b/...onTests/test_provider_when_calling_update_record_with_fqdn_name_should_modify_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]

diff --git a/...onTests/test_provider_when_calling_update_record_with_full_name_should_modify_record.yaml b/...onTests/test_provider_when_calling_update_record_with_full_name_should_modify_record.yaml
@@ -9,9 +9,9 @@ interactions:
       Content-Type: [application/json]
       User-Agent: [python-requests/2.18.4]
     method: GET
-    uri: https://api.dreamhost.com/?cmd=domain-list_domains&format=json
+    uri: https://api.dreamhost.com/?cmd=dns-list_records&format=json
   response:
-    body: {string: !!python/unicode '{"result":"success","data":[{"domain":"lexicon-example.com"}]}'}
+    body: {string: !!python/unicode '{"result":"success","data":[{"type":"A","record":"lexicon-example.com"}]}'}
     headers:
       access-control-allow-origin: ['*']
       connection: [keep-alive]