pypdfium2 4.19.0 #2

boldorider4 · 2023-08-17T21:38:54Z

Jira: PKG-2559
Upstream project: pypdfium2 requirements

anaconda-pkg-build · 2023-08-17T21:39:49Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:22: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:50: invalid_url: https://pypdfium2.readthedocs.io/en/stable : URL domain redirect pypdfium2.readthedocs.io ->
ERROR: clone/recipe/meta.yaml:51: missing_license_family: The recipe is missing the about/license_family key.
WARNING: clone/recipe/meta.yaml:51: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:51: missing_home: The recipe is missing a homepage URL
Errors were found

anaconda-pkg-build · 2023-08-18T09:30:17Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:22: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:50: invalid_url: https://pypdfium2.readthedocs.io/en/stable : URL domain redirect pypdfium2.readthedocs.io ->
WARNING: clone/recipe/meta.yaml:51: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:51: missing_home: The recipe is missing a homepage URL
ERROR: clone/recipe/meta.yaml:51: missing_license_family: The recipe is missing the about/license_family key.
Errors were found

anaconda-pkg-build · 2023-08-22T09:17:36Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:25: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:53: invalid_url: https://pypdfium2.readthedocs.io/en/stable : URL domain redirect pypdfium2.readthedocs.io ->
ERROR: clone/recipe/meta.yaml:54: missing_license_family: The recipe is missing the about/license_family key.
WARNING: clone/recipe/meta.yaml:54: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:54: missing_home: The recipe is missing a homepage URL
Errors were found

anaconda-pkg-build · 2023-08-23T18:22:36Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:26: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
INFO: clone/recipe/meta.yaml:55: invalid_url: https://pypdfium2.readthedocs.io/en/stable : URL domain redirect pypdfium2.readthedocs.io ->
WARNING: clone/recipe/meta.yaml:56: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:56: missing_home: The recipe is missing a homepage URL
ERROR: clone/recipe/meta.yaml:56: missing_license_family: The recipe is missing the about/license_family key.
Errors were found

anaconda-pkg-build · 2023-08-29T17:47:36Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:62: missing_license_family: The recipe is missing the about/license_family key.
WARNING: clone/recipe/meta.yaml:62: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:62: missing_home: The recipe is missing a homepage URL
Errors were found

mara004 · 2023-08-29T19:44:26Z

I just viewed the patch. Please see bblanchon/pdfium-binaries#119 (comment) for an idea how your goal could be achieved already without any changes to pypdfium2's code.

Probably you have realized this already, but FWIW the current patch (f869bfa) is thoroughly inappropriate. You really should not go commenting out large parts of intentional code. This completely breaks the intended use case, so it is not mergeable. And it is also not maintainable in this feedstock. Instead, if you want to run a different code passage, this can simply be controlled through the top level setup.py, as is implemented already with $PDFIUM_PLATFORM=none. Sorry for writing so bluntly. As the person who wrote the code, it's just a bit of a shock to see such a patch. 😅

PS: The ctypesgen call style improvement of the patch is good, but was already implemented independently in devel_v5.

mara004 · 2023-08-29T21:24:06Z

BTW, regarding commit 7dbe156, pillow is meant to be optional at runtime, only a subset of features depends on it (e.g. the rendering CLI). So no need to specify it as hard dependency.
A related oversight introduced in the devel_v5 branch was recently fixed, see pypdfium2-team/pypdfium2#249. main should be OK though.

anaconda-pkg-build · 2023-08-30T14:25:38Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
WARNING: clone/recipe/meta.yaml:62: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:62: missing_home: The recipe is missing a homepage URL
ERROR: clone/recipe/meta.yaml:62: missing_license_family: The recipe is missing the about/license_family key.
Errors were found

anaconda-pkg-build · 2023-08-30T20:10:27Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:32: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: clone/recipe/meta.yaml:63: missing_license_family: The recipe is missing the about/license_family key.
WARNING: clone/recipe/meta.yaml:63: missing_license_file: The recipe is missing the about/license_file or about/license_url key.
ERROR: clone/recipe/meta.yaml:63: missing_home: The recipe is missing a homepage URL
Errors were found

anaconda-pkg-build · 2023-08-31T23:06:47Z

Linter check found the following problems:

The following problems have been found:

ERROR: clone/recipe/meta.yaml:26: no_git_on_windows: git should not be used as a dependency on Windows.
Errors were found

This reverts commit 6199efb.

recipe/meta.yaml

- Add PDFIUM_PLATFORM=none - Add to script - Disable patches - Disable git in build - Disable pillow in run

M-Waszkiewicz-Anaconda

LGTM

skupr-anaconda

LGTM

recipe/meta.yaml

mara004 · 2023-09-04T18:14:46Z

recipe/meta.yaml

+    - python
+    - pdfium-binaries 118.0.5868
+    # to run pypdfium2 imgtopdf you need to have pillow
+    - pillow


As mentioned in #2 (comment), pillow is supposed to be optional, only a subset of features depends on it.
i.e. it's not strictly necessary for all use cases. But it may still be OK to keep since it's very commonly needed (upstream, we got repeated questions why pillow is not in the pyproject dependencies).

recipe/meta.yaml

JeanChristopheMorinPerso · 2023-09-05T16:40:48Z

There is a GH outage (https://www.githubstatus.com/incidents/smdz34v7j8q0) so I can't hit the approve button. But I approve.

boldorider4 added 8 commits August 8, 2023 20:46

add skeleton recipe

cd045f1

complete recipe

0a86f2b

do not specify lower bound for python

fe7c0f3

include every license file

f9fb0bf

set url to proper tar gz address

fe0a9b2

remove noarch

4b71998

pin ctypesgen to pypdfium2-team specific version

0f348c8

fix pinning

4d85183

fix version pinning

51dffb4

add git and c compiler to build

d2a4216

boldorider4 mentioned this pull request Aug 22, 2023

repack pdfium 118.0.5961 binaries AnacondaRecipes/pdfium-binaries-feedstock#1

Merged

pin pdfium-binaries to host and run

30793a3

boldorider4 added 3 commits August 29, 2023 19:41

fix build script

efedddd

patch upstream project so it can be built as a conda package

f869bfa

add pillow as run dependency

7dbe156

boldorider4 force-pushed the pkg-2559_build_4.18.0 branch from 7aa5e9b to 7dbe156 Compare August 29, 2023 17:44

add abs.yaml

2ad7775

package reference binding on linux

b9cc0da

boldorider4 force-pushed the pkg-2559_build_4.18.0 branch from 85a47f9 to b9cc0da Compare August 30, 2023 20:09

boldorider4 added 2 commits August 30, 2023 22:21

remove abs.yaml

286e809

skip archs for which no pdfium binaries exist

021bace

regenerate patches

4fd402c

M-Waszkiewicz-Anaconda force-pushed the pkg-2559_build_4.18.0 branch from 7ce03f1 to 4fd402c Compare August 31, 2023 23:17

M-Waszkiewicz-Anaconda added 4 commits September 1, 2023 01:21

use latest ctypesgen-pypdfium2-team

6199efb

Revert "use latest ctypesgen-pypdfium2-team"

7ffda59

This reverts commit 6199efb.

use latest ctypesgen-pypdfium2-team

99354aa

add abs.yaml

b66a9bf

JeanChristopheMorinPerso reviewed Sep 1, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

JeanChristopheMorinPerso reviewed Sep 1, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

M-Waszkiewicz-Anaconda and others added 3 commits September 1, 2023 16:06

remove the build package requirement

4c9b099

Update to 4.19.0:

d6a6836

- Add PDFIUM_PLATFORM=none - Add to script - Disable patches - Disable git in build - Disable pillow in run

add pillow, clean up

4e19a47

M-Waszkiewicz-Anaconda approved these changes Sep 4, 2023

View reviewed changes

skupr-anaconda approved these changes Sep 4, 2023

View reviewed changes

skupr-anaconda changed the title ~~build 4.18.0~~ pypdfium2 4.19.0 Sep 4, 2023

skupr-anaconda requested review from JeanChristopheMorinPerso and mara004 September 4, 2023 14:04

mara004 reviewed Sep 4, 2023

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

mara004 reviewed Sep 4, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

mara004 reviewed Sep 4, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

update pdfium-binaries dependency

66aee25

JeanChristopheMorinPerso reviewed Sep 5, 2023

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Outdated Show resolved Hide resolved

remove compiler, pdfium license

76c7a15

M-Waszkiewicz-Anaconda requested review from JeanChristopheMorinPerso and skupr-anaconda September 5, 2023 14:57

skupr-anaconda approved these changes Sep 5, 2023

View reviewed changes

M-Waszkiewicz-Anaconda merged commit 1077be2 into main Sep 5, 2023

M-Waszkiewicz-Anaconda deleted the pkg-2559_build_4.18.0 branch September 5, 2023 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pypdfium2 4.19.0 #2

pypdfium2 4.19.0 #2

boldorider4 commented Aug 17, 2023 •

edited by jira bot

Loading

anaconda-pkg-build commented Aug 17, 2023

anaconda-pkg-build commented Aug 18, 2023

anaconda-pkg-build commented Aug 22, 2023

anaconda-pkg-build commented Aug 23, 2023

anaconda-pkg-build commented Aug 29, 2023

mara004 commented Aug 29, 2023 •

edited

Loading

mara004 commented Aug 29, 2023

anaconda-pkg-build commented Aug 30, 2023

anaconda-pkg-build commented Aug 30, 2023

anaconda-pkg-build commented Aug 31, 2023

M-Waszkiewicz-Anaconda left a comment

skupr-anaconda left a comment

mara004 Sep 4, 2023 •

edited

Loading

JeanChristopheMorinPerso commented Sep 5, 2023

pypdfium2 4.19.0 #2

pypdfium2 4.19.0 #2

Conversation

boldorider4 commented Aug 17, 2023 • edited by jira bot Loading

anaconda-pkg-build commented Aug 17, 2023

anaconda-pkg-build commented Aug 18, 2023

anaconda-pkg-build commented Aug 22, 2023

anaconda-pkg-build commented Aug 23, 2023

anaconda-pkg-build commented Aug 29, 2023

mara004 commented Aug 29, 2023 • edited Loading

mara004 commented Aug 29, 2023

anaconda-pkg-build commented Aug 30, 2023

anaconda-pkg-build commented Aug 30, 2023

anaconda-pkg-build commented Aug 31, 2023

M-Waszkiewicz-Anaconda left a comment

Choose a reason for hiding this comment

skupr-anaconda left a comment

Choose a reason for hiding this comment

mara004 Sep 4, 2023 • edited Loading

Choose a reason for hiding this comment

JeanChristopheMorinPerso commented Sep 5, 2023

boldorider4 commented Aug 17, 2023 •

edited by jira bot

Loading

mara004 commented Aug 29, 2023 •

edited

Loading

mara004 Sep 4, 2023 •

edited

Loading