new 1.8 version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Waszkiewicz-Anaconda
force-pushed
the
PKG-3018
branch
from
0b2d2fc
to
7306e31
Compare
|
looks like the problem is with the underlying services providing forex-data, I have asked snowflake if we should publish even though it does not work at the moment |
|
Not a funny warning https://github.com/MicroPyramid/forex-python#forex-python: See this diff MicroPyramid/forex-python@1.6...v1.8 |
yeah, that is really bad if the latest version does not work, I have asked snowflake what should we do |
boldorider4
reviewed
Oct 27, 2023
boldorider4
reviewed
Oct 27, 2023
M-Waszkiewicz-Anaconda
force-pushed
the
PKG-3018
branch
from
e67ddb9
to
13ddc13
Compare
M-Waszkiewicz-Anaconda
force-pushed
the
PKG-3018
branch
from
13ddc13
to
c7de96a
Compare
M-Waszkiewicz-Anaconda
force-pushed
the
PKG-3018
branch
from
c7de96a
to
d9a2e05
Compare
M-Waszkiewicz-Anaconda
requested review from
JeanChristopheMorinPerso and
boldorider4
JeanChristopheMorinPerso
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forex python 1.8 for snowflake
! Tried 1.6 version which according to readme should work: #2
however it does not, agreed with snowflake that if earlier version does not work we would deliver the latest even though test are failing