Revert "fix build for latest boost, skip test on windows"

This reverts commit 49e383f. Signed-off-by: akarin <[email protected]>
AmusementClub · Feb 21, 2023 · 7e1cc63 · 7e1cc63
1 parent fe22032
commit 7e1cc63
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 13 deletions.
diff --git a/.github/workflows/gha-ci.yml b/.github/workflows/gha-ci.yml
@@ -2,7 +2,7 @@ name: GitHubActions CI tests
 
 on:
   push:
-    branches: [master, dev, ci, mod]
+    branches: [master, dev, ci]
   # pull_request:
   workflow_dispatch:
 
@@ -180,8 +180,6 @@ jobs:
         MSBuild.exe Aegisub.vcxproj -p:Configuration=Release
 
     - name: run tests
-      # latest boost broke the build for tests/vfr.cpp.
-      if: false
       run: |
         Set-Location build-dir
         MSBuild.exe test.vcxproj -p:Configuration=Release

diff --git a/libaegisub/include/libaegisub/lua/utils.h b/libaegisub/include/libaegisub/lua/utils.h
@@ -22,7 +22,6 @@
 #include <type_traits>
 
 #include <boost/config.hpp>
-#include <boost/flyweight.hpp>
 
 #ifndef BOOST_NORETURN
 #include <boost/exception/detail/attribute_noreturn.hpp>
@@ -78,12 +77,6 @@ void push_value(lua_State *L, std::vector<T> const& value) {
 	}
 }
 
-template<typename T>
-inline void push_value(lua_State *L, boost::flyweight<T> const& value) {
-	const T& v = value;
-	push_value(L, v);
-}
-
 int exception_wrapper(lua_State *L, int (*func)(lua_State *L));
 /// Wrap a function which may throw exceptions and make it trigger lua errors
 /// whenever it throws

diff --git a/src/auto4_lua.cpp b/src/auto4_lua.cpp
@@ -119,7 +119,7 @@ namespace {
 	int get_translation(lua_State *L)
 	{
 		wxString str(check_wxstring(L, 1));
-		push_value(L, (const char *)_(str).utf8_str());
+		push_value(L, _(str).utf8_str());
 		return 1;
 	}
 

diff --git a/src/command/video.cpp b/src/command/video.cpp
@@ -475,7 +475,7 @@ static void save_snapshot(agi::Context *c, bool raw) {
 		// If where ever that is isn't defined, we can't save there
 		if ((basepath == "\\") || (basepath == "/")) {
 			// So save to the current user's home dir instead
-			basepath = (const char*)wxGetHomeDir().c_str();
+			basepath = wxGetHomeDir().c_str();
 		}
 	}
 	// Actual fixed (possibly relative) path, decode it

diff --git a/src/dialog_attachments.cpp b/src/dialog_attachments.cpp
@@ -161,7 +161,7 @@ void DialogAttachments::OnExtract(wxCommandEvent &) {
 
 	// Multiple or single?
 	if (listView->GetNextSelected(i) != -1)
-		path = (const char*)wxDirSelector(_("Select the path to save the files to:"), to_wx(OPT_GET("Path/Fonts Collector Destination")->GetString())).c_str();
+		path = wxDirSelector(_("Select the path to save the files to:"), to_wx(OPT_GET("Path/Fonts Collector Destination")->GetString())).c_str();
 	else {
 		path = SaveFileSelector(
 			_("Select the path to save the file to:"),