Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Silex to Symfony4 #38

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rpkamp
Copy link

@rpkamp rpkamp commented Jun 22, 2019

@rdohms: "I expect a PR to migrate our Silex raffler to Symfony 4"

me:
challenge accepted!

@rpkamp rpkamp changed the title Symfony4 Migrate from Silex to Symfony4 Jun 22, 2019
@rdohms
Copy link
Member

rdohms commented Jun 22, 2019

😃 👏 will take a closer look tomorrow, thanks!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@pascaldevink pascaldevink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things left, but everything seems to work as it should 👍

@rdohms when checking, don't forget to git submodule update or you'll run into trouble 😄 and we have to figure out

  1. how to deploy this
  2. how to get your changes from production in here as well

@rdohms
Copy link
Member

rdohms commented Jun 23, 2019

My changes from production are... GREAT, but should probably be sacrificed in 🔥 . I'll just add them once we are done. It was essentially making 2 calls, the second with offset=>1.

Deploying, indeed, i think the best scenario is figuring out a capistrano-like way and re-setting it up. What are kids using nowadays, don't say docker.

@rpkamp
Copy link
Author

rpkamp commented Jun 23, 2019

What are kids using nowadays, don't say docker.

Not sure what others use, but I love deployments with the Ansible deployment helper

@pascaldevink
Copy link
Member

Deploying, indeed, i think the best scenario is figuring out a capistrano-like way and re-setting it up. What are kids using nowadays, don't say docker.

Think we can just reuse what we already have with CircleCI currently. It's just not doing to automatically anymore, since the config is written for CircleCI v1 and they don't support that anymore. Other than that, ./vendor/bin/dep deploy probably still works given you have the right private key 😄

@rdohms
Copy link
Member

rdohms commented Jun 26, 2019

i'll look into the current deploy over the weekend

@rdohms
Copy link
Member

rdohms commented Jul 19, 2019

I'm getting this while doing a composer install:

Script cache:clear returned with error code 1
!!
!!  In FileLoader.php line 166:
!!
!!    There is no extension able to load the configuration for "meetup_group" (in
!!     /home/circleci/project/config/parameters.yml). Looked for namespace "meetu
!!    p_group", found "framework", "snc_redis", "monolog", "twig", "sensio_framew
!!    ork_extra", "web_profiler", "debug", "webpack_encore" in /home/circleci/pro
!!    ject/config/parameters.yml (which is loaded in resource "/home/circleci/pro
!!    ject/config/parameters.yml").
!!
!!
!!  In YamlFileLoader.php line 683:
!!
!!    There is no extension able to load the configuration for "meetup_group" (in
!!     /home/circleci/project/config/parameters.yml). Looked for namespace "meetu
!!    p_group", found "framework", "snc_redis", "monolog", "twig", "sensio_framew
!!    ork_extra", "web_profiler", "debug", "webpack_encore"
!!
!!
!!
Script @auto-scripts was called via post-install-cmd

@rpkamp any ideas why? followed the parameters file you described in readme

@rdohms
Copy link
Member

rdohms commented Jul 19, 2019

nevermind, i'm an idiot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants