-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Silex to Symfony4 #38
base: master
Are you sure you want to change the base?
Conversation
😃 👏 will take a closer look tomorrow, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things left, but everything seems to work as it should 👍
@rdohms when checking, don't forget to git submodule update
or you'll run into trouble 😄 and we have to figure out
- how to deploy this
- how to get your changes from production in here as well
My changes from production are... GREAT, but should probably be sacrificed in 🔥 . I'll just add them once we are done. It was essentially making 2 calls, the second with Deploying, indeed, i think the best scenario is figuring out a capistrano-like way and re-setting it up. What are kids using nowadays, don't say docker. |
Not sure what others use, but I love deployments with the Ansible deployment helper |
Think we can just reuse what we already have with CircleCI currently. It's just not doing to automatically anymore, since the config is written for CircleCI v1 and they don't support that anymore. Other than that, |
i'll look into the current deploy over the weekend |
I'm getting this while doing a composer install:
@rpkamp any ideas why? followed the parameters file you described in readme |
nevermind, i'm an idiot |
@rdohms: "I expect a PR to migrate our Silex raffler to Symfony 4"
me: