MIJN-9980-BUG/geblokkeerde-passen-worden-eruit-gefiltert #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RoanPaulus
commented
Jan 23, 2025
•
RoanPaulus
commented
- Adjusted filter to only filter out replaced passes or expired passes.
- Refactored tests so these are easier to manage. Now cleans up after every test and creating passes are more flexible/readable.
- Changed a happy path test into testing the filter, effectively testing both things at once.
RoanPaulus
changed the title
* Fix test * Reset mocks?!
RoanPaulus
force-pushed
the
MIJN-9980/BUG-geblokkeerde-passen-worden-eruit-gefiltert
branch
from
b9373e8 to
5bacb09
Compare
…on the default expiry date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.