adds network connectivity and use build time and runtime arguments #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meldingen
Ticket: https://gemeente-amsterdam.atlassian.net/browse/SIG-6336
This PR attaches the frontend to a Docker network that is created in the backend (therefore you will need to always startup the backend first).
Furthermore it creates a distinction between runtime variables which are used for the serverside part of NextJS and build time variables which are used on the client side part.
See also: https://nextjs.org/docs/pages/building-your-application/configuring/environment-variables