Raise explicit exception to clarify what couldn't be found

meldingen_core/classification.py

@@ -1,9 +1,13 @@
 from abc import ABCMeta, abstractmethod
 
+from meldingen_core.exceptions import NotFoundException
 from meldingen_core.models import Classification
 from meldingen_core.repositories import BaseClassificationRepository
 
 
+class ClassificationNotFoundException(NotFoundException): ...
+
+
 class BaseClassifierAdapter(metaclass=ABCMeta):
     @abstractmethod
     async def __call__(self, text: str) -> str:
@@ -21,4 +25,7 @@ def __init__(self, adapter: BaseClassifierAdapter, repository: BaseClassificatio
     async def __call__(self, text: str) -> Classification:
         name = await self._adapter(text)
 
-        return await self._repository.find_by_name(name)
+        try:
+            return await self._repository.find_by_name(name)
+        except NotFoundException as exception:
+            raise ClassificationNotFoundException() from exception

tests/test_classification.py

@@ -2,7 +2,8 @@
 
 import pytest
 
-from meldingen_core.classification import BaseClassifierAdapter, Classifier
+from meldingen_core.classification import BaseClassifierAdapter, ClassificationNotFoundException, Classifier
+from meldingen_core.exceptions import NotFoundException
 from meldingen_core.models import Classification
 from meldingen_core.repositories import BaseClassificationRepository
 
@@ -20,3 +21,14 @@ async def test_classifier() -> None:
     assert classification.name == "classification_name"
     adapter.assert_called_once_with("text")
     repository.find_by_name.assert_called_once_with("classification_name")
+
+
+@pytest.mark.asyncio
+async def test_classifier_classification_not_found() -> None:
+    adapter = AsyncMock(BaseClassifierAdapter, return_value="classification_name")
+    repository = Mock(BaseClassificationRepository)
+    repository.find_by_name = AsyncMock(side_effect=NotFoundException())
+    classify = Classifier(adapter, repository)
+
+    with pytest.raises(ClassificationNotFoundException):
+        await classify("text")