Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle single quotes in make_indexjson.py #416

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Handle single quotes in make_indexjson.py #416

merged 1 commit into from
Nov 13, 2023

Conversation

lbam
Copy link
Contributor

@lbam lbam commented Nov 6, 2023

These occur in our generated mapfiles. Diff of output on the mapfiles in the top-level dir:

26c26,29
<   "beschermdestadsdorpsgezichten": {},
---
>   "beschermdestadsdorpsgezichten": {
>     "abstract": "Kaart met gegevens over beschermde stads- en dorpsgezichten in de gemeente Amsterdam",
>     "title": "Beschermde stads- en dorpsgezichten"
>   },
47c50,53
<   "bomen": {},
---
>   "bomen": {
>     "abstract": "Dataset met actuele informatie over de bomen in beheer van gemeente Amsterdam",
>     "title": "Objecten openbare ruimte - bomen"
>   },
249c255,258
<   "overlastgebieden": {},
---
>   "overlastgebieden": {
>     "abstract": "Overlastgebieden",
>     "title": "Overlastgebieden"
>   },
338c347,350
<   "ziektenplagenexotengroen": {}
---
>   "ziektenplagenexotengroen": {
>     "abstract": "Kaart met gegevens over ziekten, plagen en exoten in het groen in de gemeente Amsterdam",
>     "title": "Ziekte, plagen, exoten, groen"
>   }

These occur in our generated mapfiles. Diff of output on the mapfiles in
the top-level dir:

    26c26,29
    <   "beschermdestadsdorpsgezichten": {},
    ---
    >   "beschermdestadsdorpsgezichten": {
    >     "abstract": "Kaart met gegevens over beschermde stads- en dorpsgezichten in de gemeente Amsterdam",
    >     "title": "Beschermde stads- en dorpsgezichten"
    >   },
    47c50,53
    <   "bomen": {},
    ---
    >   "bomen": {
    >     "abstract": "Dataset met actuele informatie over de bomen in beheer van gemeente Amsterdam",
    >     "title": "Objecten openbare ruimte - bomen"
    >   },
    249c255,258
    <   "overlastgebieden": {},
    ---
    >   "overlastgebieden": {
    >     "abstract": "Overlastgebieden",
    >     "title": "Overlastgebieden"
    >   },
    338c347,350
    <   "ziektenplagenexotengroen": {}
    ---
    >   "ziektenplagenexotengroen": {
    >     "abstract": "Kaart met gegevens over ziekten, plagen en exoten in het groen in de gemeente Amsterdam",
    >     "title": "Ziekte, plagen, exoten, groen"
    >   }
Copy link
Contributor

@jjmurre jjmurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjmurre jjmurre merged commit d642d1b into master Nov 13, 2023
2 checks passed
@jjmurre jjmurre deleted the lb/indexjson branch November 13, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants